From 4e610b7f6b25a9540ee01dd69e2fc29b9679c810 Mon Sep 17 00:00:00 2001 From: Matthijs Mekking Date: Tue, 10 Mar 2020 13:29:35 +0100 Subject: [PATCH] Disable kasp test on Windows The kasp system test is timing critical. The test passes on all Linux based machines, but fails frequently on Windows. The test takes a lot more time on Windows and at the final checks fail because the expected next key event is too far off. For example: I:kasp:check next key event for zone step2.algorithm-roll.kasp (570) I:kasp:error: bad next key event time 20909 for zone \ step2.algorithm-roll.kasp (expect 21600) I:kasp:failed This is because the kasp system test calculates the time when the next key event should occur based on the policy. This assumes that named is able to do key management within a minute. But starting, named, doing key management for other zones, and reconfiguring takes much more time on Windows and thus the next key event on Windows is much shorter than anticipated. That this happens is a good thing because this means that the correct next key event is used, but is not so nice for testing, as it is hard to determine how much time named needed before finishing the current key event. Disable the kasp test on Windows now because it is blocking the release. We know the cause of these test failures, and it is clear that this is a fault in the test, not the code. Therefore we feel comfortable disabling the test right now and work on a fix while unblocking the release. --- bin/tests/system/kasp/prereq.sh | 19 +++++++++++++++++++ util/copyrights | 1 + 2 files changed, 20 insertions(+) create mode 100644 bin/tests/system/kasp/prereq.sh diff --git a/bin/tests/system/kasp/prereq.sh b/bin/tests/system/kasp/prereq.sh new file mode 100644 index 0000000000..7a20dcdb38 --- /dev/null +++ b/bin/tests/system/kasp/prereq.sh @@ -0,0 +1,19 @@ +#!/bin/sh +# +# Copyright (C) Internet Systems Consortium, Inc. ("ISC") +# +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. +# +# See the COPYRIGHT file distributed with this work for additional +# information regarding copyright ownership. + +SYSTEMTESTTOP=.. +. $SYSTEMTESTTOP/conf.sh + +if [ "$CYGWIN" ]; then + echo_i "KASP test disabled on Windows for now due to timing issues" + exit 255 +fi +exit 0 diff --git a/util/copyrights b/util/copyrights index 8bc98fa185..bdf10cda34 100644 --- a/util/copyrights +++ b/util/copyrights @@ -698,6 +698,7 @@ ./bin/tests/system/kasp/ns4/setup.sh SH 2019,2020 ./bin/tests/system/kasp/ns5/setup.sh SH 2019,2020 ./bin/tests/system/kasp/ns6/setup.sh SH 2020 +./bin/tests/system/kasp/prereq.sh SH 2020 ./bin/tests/system/kasp/setup.sh SH 2019,2020 ./bin/tests/system/kasp/tests.sh SH 2019,2020 ./bin/tests/system/keepalive/clean.sh SH 2017,2018,2019,2020