mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-09-02 07:35:26 +00:00
Code Issues Releases Wiki Activity

4462. [bug] Don't describe a returned EDNS COOKIE as "good"

Browse Source 
when there isn't a valid server cookie. [RT #43167]
This commit is contained in:
Mark Andrews
2016-09-08 11:34:19 +10:00
parent da8353706f
commit 58d622d96d
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGES
View File

@@ -1,3 +1,6 @@
4462. [bug] Don't describe a returned EDNS COOKIE as "good"
when there isn't a valid server cookie. [RT #43167]
4461. [bug] win32: not all external data was properly marked 4461. [bug] win32: not all external data was properly marked
as external data for windows dll. [RT #43161] as external data for windows dll. [RT #43161]

15
lib/dns/message.c
View File

@@ -3426,8 +3426,21 @@ dns_message_pseudosectiontotext(dns_message_t *msg,
isc_buffer_forward(&optbuf, optlen); isc_buffer_forward(&optbuf, optlen);
if (optcode == DNS_OPT_COOKIE) { if (optcode == DNS_OPT_COOKIE) {
if (msg->cc_ok) /*
* Valid server cookie?
*/
if (msg->cc_ok && optlen >= 16)
ADD_STRING(target, " (good)"); ADD_STRING(target, " (good)");
/*
* Server cookie is not valid but
* we had our cookie echoed back.
*/
if (msg->cc_ok && optlen < 16)
ADD_STRING(target, " (echoed)");
/*
* We didn't get our cookie echoed
* back.
*/
if (msg->cc_bad) if (msg->cc_bad)
ADD_STRING(target, " (bad)"); ADD_STRING(target, " (bad)");
ADD_STRING(target, "\n"); ADD_STRING(target, "\n");