From 2db529057980d2fd879b2d8a5d94487042db215a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Sur=C3=BD?= Date: Wed, 26 May 2021 10:01:30 +0200 Subject: [PATCH] Fix the sizeof() for array holding the pointers to clientmgr The size of the array holding the pointers to clientmgr was created so big it could hold the actual clientmgr objects, not just the pointer. This commit fixes the size to be just the ncpus * sizeof(pointer). --- lib/ns/interfacemgr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ns/interfacemgr.c b/lib/ns/interfacemgr.c index 1ff6bcb859..54e2ed7a69 100644 --- a/lib/ns/interfacemgr.c +++ b/lib/ns/interfacemgr.c @@ -272,7 +272,7 @@ ns_interfacemgr_create(isc_mem_t *mctx, ns_server_t *sctx, *mgrp = mgr; mgr->clientmgrs = isc_mem_get(mgr->mctx, - mgr->ncpus * sizeof(*mgr->clientmgrs[0])); + mgr->ncpus * sizeof(mgr->clientmgrs[0])); for (size_t i = 0; i < (size_t)mgr->ncpus; i++) { result = ns_clientmgr_create(mgr->sctx, mgr->taskmgr, mgr->timermgr, mgr->aclenv, (int)i, @@ -333,7 +333,7 @@ ns_interfacemgr_destroy(ns_interfacemgr_t *mgr) { ns_clientmgr_destroy(&mgr->clientmgrs[i]); } isc_mem_put(mgr->mctx, mgr->clientmgrs, - mgr->ncpus * sizeof(*mgr->clientmgrs[0])); + mgr->ncpus * sizeof(mgr->clientmgrs[0])); if (mgr->sctx != NULL) { ns_server_detach(&mgr->sctx);