Merge branch '1088-always-fail-a-system-test-if-crashes-are-detected' into 'master'

Always fail a system test if crashes are detected

Closes #1088

See merge request isc-projects/bind9!2041

bin/tests/system/run.sh

@@ -188,8 +188,18 @@ status=`expr $status + $?`
 if [ $status != 0 ]; then
     echofail "R:$systest:FAIL"
     # Do not clean up - we need the evidence.
-    find . -name core -exec chmod 0644 '{}' \;
 else
+    core_dumps="$(find $systest/ -name 'core*' | sort | tr '\n' ' ')"
+    assertion_failures=$(find $systest/ -name named.run | xargs grep "assertion failure" | wc -l)
+    if [ -n "$core_dumps" ]; then
+        echoinfo "I:$systest:Test claims success despite crashes: $core_dumps"
+        echofail "R:$systest:FAIL"
+        # Do not clean up - we need the evidence.
+    elif [ $assertion_failures -ne 0 ]; then
+        echoinfo "I:$systest:Test claims success despite $assertion_failures assertion failure(s)"
+        echofail "R:$systest:FAIL"
+        # Do not clean up - we need the evidence.
+    else
         echopass "R:$systest:PASS"
         if $clean
         then
@@ -202,6 +212,7 @@ else
                 -e 's|^!! \(.*/named.memstats\)$|I:file \1 not removed|p'
             fi
         fi
+    fi
 fi
 
 echoend "E:$systest:`date $dateargs`"