From 5ef71c420fc118b506ad5a16bdb4a21fafdcda9c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Sur=C3=BD?= Date: Thu, 22 Oct 2020 00:17:03 +0200 Subject: [PATCH] Ignore and don't log ISC_R_NOTCONNECTED from uv_accept() When client disconnects before the connection can be accepted, the named would log a spurious log message: error: Accepting TCP connection failed: socket is not connected We now ignore the ISC_R_NOTCONNECTED result code and log only other errors --- lib/isc/netmgr/tcp.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/lib/isc/netmgr/tcp.c b/lib/isc/netmgr/tcp.c index 5129e1d4a5..ef575ee502 100644 --- a/lib/isc/netmgr/tcp.c +++ b/lib/isc/netmgr/tcp.c @@ -517,9 +517,17 @@ error: if (sock->quota != NULL) { isc_quota_detach(&sock->quota); } - isc_log_write(isc_lctx, ISC_LOGCATEGORY_GENERAL, ISC_LOGMODULE_NETMGR, - ISC_LOG_ERROR, "Accepting TCP connection failed: %s", - isc_result_totext(result)); + + switch (result) { + case ISC_R_NOTCONNECTED: + /* IGNORE: The client disconnected before we could accept */ + break; + default: + isc_log_write(isc_lctx, ISC_LOGCATEGORY_GENERAL, + ISC_LOGMODULE_NETMGR, ISC_LOG_ERROR, + "Accepting TCP connection failed: %s", + isc_result_totext(result)); + } /* * Detach the socket properly to make sure uv_close() is called.