mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-31 14:35:26 +00:00
Code Issues Releases Wiki Activity

netmgr: close uv_loop properly

Browse Source 
close the uv_handle for the worker async channel, and call
uv_loop_close() on shutdown to ensure that the event loop's
internal resources are properly freed.
This commit is contained in:
Witold Kręcicki
2019-11-15 12:15:03 +01:00
committed by Evan Hunt
parent 6718a4ef8b
commit 62a8405fa2
1 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/isc/netmgr/netmgr.c
View File

@@ -174,6 +174,8 @@ nm_destroy(isc_nm_t **mgr0) {
isc_mem_put(mgr->mctx, ievent,
sizeof(isc__netievent_storage_t));
}
int r = uv_loop_close(&mgr->workers[i].loop);
INSIST(r == 0);
isc_queue_destroy(mgr->workers[i].ievents);
isc_mempool_destroy(&mgr->workers[i].mpool_bufs);
}
@@ -350,6 +352,16 @@ nm_thread(void *worker0) {
if (worker->finished) {
/* TODO walk the handles and free them! */
/*
* We need to launch the loop one more time
* to make sure that worker->async is closed,
* so that we can close the loop cleanly.
* We don't care about the callback as in this
* case we can be certain that uv_run will
* eat this event.
*/
uv_close((uv_handle_t *)&worker->async, NULL);
uv_run(&worker->loop, UV_RUN_NOWAIT);
break;
}