mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-30 22:15:20 +00:00
Code Issues Releases Wiki Activity

Require to be dereferenced arguments are non-NULL

Browse Source 
The function 'dns_dnssec_syncupdate()' is dereferencing arguments
'keys' and 'rmkeys'. There should be a REQUIRE that those are not
null pointers.
This commit is contained in:
Matthijs Mekking
2023-02-22 12:12:15 +01:00
parent b1633b71b0
commit 6c76a99c24
2 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/dns/dnssec.c
View File

@@ -2033,6 +2033,8 @@ dns_dnssec_syncupdate(dns_dnsseckeylist_t *keys, dns_dnsseckeylist_t *rmkeys,
dns_dnsseckey_t *key; dns_dnsseckey_t *key;
REQUIRE(digests != NULL); REQUIRE(digests != NULL);
REQUIRE(keys != NULL);
REQUIRE(rmkeys != NULL);
for (key = ISC_LIST_HEAD(*keys); key != NULL; for (key = ISC_LIST_HEAD(*keys); key != NULL;
key = ISC_LIST_NEXT(key, link)) key = ISC_LIST_NEXT(key, link))

2
lib/dns/include/dns/dnssec.h
View File

@@ -371,6 +371,8 @@ dns_dnssec_syncupdate(dns_dnsseckeylist_t *keys, dns_dnsseckeylist_t *rmkeys,
* Any changes made also cause a dns_difftuple to be added to 'diff'. * Any changes made also cause a dns_difftuple to be added to 'diff'.
* *
* Requires: * Requires:
*\li 'keys' is not NULL.
*\li 'rmkeys' is not NULL.
*\li 'digests' is not NULL. *\li 'digests' is not NULL.
* *
* Returns: * Returns: