From 6ef0417274e451340b27f66c31808e4f79c65bc8 Mon Sep 17 00:00:00 2001 From: Matthijs Mekking Date: Wed, 9 Nov 2022 14:45:06 +0100 Subject: [PATCH] Tweak kasp system test script The retry 3 times when checking signatures did not make sense because at this point the input file does not change. Raise the number of retries when checking the apex DNSKEY response to reduce the number of intermittent failures due to unexpected delays. --- bin/tests/system/kasp.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bin/tests/system/kasp.sh b/bin/tests/system/kasp.sh index 702a239296..f0c83b19ab 100644 --- a/bin/tests/system/kasp.sh +++ b/bin/tests/system/kasp.sh @@ -1107,7 +1107,7 @@ _check_apex_dnskey() { test "$_checksig" -eq 0 && return 0 - retry_quiet 3 _check_signatures "DNSKEY" "dig.out.$DIR.test$n" "KSK" || return 1 + _check_signatures "DNSKEY" "dig.out.$DIR.test$n" "KSK" || return 1 return 0 } @@ -1120,11 +1120,11 @@ check_apex() { n=$((n+1)) echo_i "check DNSKEY rrset is signed correctly for zone ${ZONE} ($n)" ret=0 - retry_quiet 3 _check_apex_dnskey || ret=1 + retry_quiet 10 _check_apex_dnskey || ret=1 test "$ret" -eq 0 || echo_i "failed" status=$((status+ret)) - # We retry the DNSKEY query for at most three seconds to avoid test + # We retry the DNSKEY query for at most ten seconds to avoid test # failures due to timing issues. If the DNSKEY query check passes this # means the zone is resigned and further apex checks (SOA, CDS, CDNSKEY) # don't need to be retried quietly.