mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-09-03 08:05:21 +00:00
Code Issues Releases Wiki Activity

dns_nsec3_addnsec3() can fail when iterating back

Browse Source 
when adding a new NSEC3 record, dns_nsec3_addnsec3() uses a
dbiterator to seek to the newly created node and then find its
predecessor.  dbiterators in the qpzone use snapshots, so changes
to the database are not reflected in an already-existing iterator.
consequently, when we add a new node, we have to create a new iterator
before we can seek to it.
This commit is contained in:
Evan Hunt
2024-12-20 18:31:30 -08:00
parent 3e367a23f9
commit 71e1c91695
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lib/dns/nsec3.c
View File

@@ -776,7 +776,7 @@ addnsec3:
/* /*
* Create the node if it doesn't exist and hold * Create the node if it doesn't exist and hold
* a reference to it until we have added the NSEC3 * a reference to it until we have added the NSEC3
* or we discover we don't need to add make a change. * or we discover we don't need to make a change.
*/ */
CHECK(dns_db_findnsec3node(db, hashname, true, &newnode)); CHECK(dns_db_findnsec3node(db, hashname, true, &newnode));
result = dns_db_findrdataset(db, newnode, version, result = dns_db_findrdataset(db, newnode, version,
@@ -792,6 +792,17 @@ addnsec3:
if (result != ISC_R_NOMORE) { if (result != ISC_R_NOMORE) {
goto failure; goto failure;
} }
} else if (result == ISC_R_NOTFOUND) {
/*
* If we didn't find an NSEC3 in the node,
* then the node must have been newly created
* by dns_db_findnsec3node(). The iterator
* needs to be updated so we can seek for
* the node's predecessor.
*/
dns_dbiterator_destroy(&dbit);
CHECK(dns_db_createiterator(db, DNS_DB_NSEC3ONLY,
&dbit));
} }
/* /*