From 55b48700dad6316e64ed2399b955e75881e63b28 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Sur=C3=BD?= Date: Fri, 10 May 2019 09:29:00 +0700 Subject: [PATCH] Improve the error message about missing PLY Python package Previously, only a message about missing Python was printed, which was misleading to many users. The new message clearly states that Python AND PLY is required and prints basic instructions how to install PLY package. --- configure | 2 +- configure.ac | 10 +++++++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 29bc6787d7..1c56cf5a5f 100755 --- a/configure +++ b/configure @@ -12586,7 +12586,7 @@ fi $as_echo_n "checking for Python support... " >&6; } { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 $as_echo "no" >&6; } - as_fn_error $? "Python required for dnssec-keymgr" "$LINENO" 5 + as_fn_error $? "Python >= 2.7 or >= 3.2 and the PLY package are required for dnssec-keymgr and other Python-based tools. PLY may be available from your OS package manager as python-ply or python3-ply; it can also be installed via pip. To build without Python/PLY, use --disable-python." "$LINENO" 5 fi fi diff --git a/configure.ac b/configure.ac index 837768d844..71a05e2eb1 100644 --- a/configure.ac +++ b/configure.ac @@ -262,7 +262,15 @@ AS_IF([test "$with_python" = "no"], AS_IF([test "X$PYTHON" = "X"], [AC_MSG_CHECKING([for Python support]) AC_MSG_RESULT([no]) - AC_MSG_ERROR([Python required for dnssec-keymgr])])]) + AC_MSG_ERROR([m4_normalize( + [Python >= 2.7 or >= 3.2 and the PLY package + are required for dnssec-keymgr and other + Python-based tools. PLY may be + available from your OS package manager + as python-ply or python3-ply; it can also + be installed via pip. To build without + Python/PLY, use --disable-python.] + )])])]) PYTHON_TOOLS='' CHECKDS=''