2
0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-29 13:38:26 +00:00

Make the qp-trie stats logging quieter

Only log when useful work was done
This commit is contained in:
Tony Finch 2023-02-16 21:41:02 +00:00
parent 4b5ec07bb7
commit 7dcde5d2fc

View File

@ -592,10 +592,12 @@ recycle(dns_qp_t *qp) {
isc_nanosecs_t time = isc_time_monotonic() - start; isc_nanosecs_t time = isc_time_monotonic() - start;
atomic_fetch_add_relaxed(&recycle_time, time); atomic_fetch_add_relaxed(&recycle_time, time);
LOG_STATS("qp recycle" PRItime "free %u chunks", time, free); if (free > 0) {
LOG_STATS("qp recycle after leaf %u live %u used %u free %u hold %u", LOG_STATS("qp recycle" PRItime "free %u chunks", time, free);
qp->leaf_count, qp->used_count - qp->free_count, LOG_STATS("qp recycle leaf %u live %u used %u free %u hold %u",
qp->used_count, qp->free_count, qp->hold_count); qp->leaf_count, qp->used_count - qp->free_count,
qp->used_count, qp->free_count, qp->hold_count);
}
} }
/* /*
@ -617,7 +619,10 @@ defer_chunk_reclamation(dns_qp_t *qp, isc_qsbr_phase_t phase) {
} }
} }
LOG_STATS("qp will reclaim %u chunks in phase %u", reclaim, phase); if (reclaim > 0) {
LOG_STATS("qp will reclaim %u chunks in phase %u", reclaim,
phase);
}
return (reclaim > 0); return (reclaim > 0);
} }
@ -650,11 +655,13 @@ reclaim_chunks(dns_qp_t *qp, isc_qsbr_phase_t phase) {
isc_nanosecs_t time = isc_time_monotonic() - start; isc_nanosecs_t time = isc_time_monotonic() - start;
recycle_time += time; recycle_time += time;
LOG_STATS("qp reclaim" PRItime "phase %u free %u chunks", time, phase, if (free > 0) {
free); LOG_STATS("qp reclaim" PRItime "phase %u free %u chunks", time,
LOG_STATS("qp reclaim after leaf %u live %u used %u free %u hold %u", phase, free);
qp->leaf_count, qp->used_count - qp->free_count, LOG_STATS("qp reclaim leaf %u live %u used %u free %u hold %u",
qp->used_count, qp->free_count, qp->hold_count); qp->leaf_count, qp->used_count - qp->free_count,
qp->used_count, qp->free_count, qp->hold_count);
}
return (more); return (more);
} }
@ -735,10 +742,13 @@ marksweep_chunks(dns_qpmulti_t *multi) {
isc_nanosecs_t time = isc_time_monotonic() - start; isc_nanosecs_t time = isc_time_monotonic() - start;
recycle_time += time; recycle_time += time;
LOG_STATS("qp marksweep" PRItime "free %u chunks", time, free); if (free > 0) {
LOG_STATS("qp marksweep after leaf %u live %u used %u free %u hold %u", LOG_STATS("qp marksweep" PRItime "free %u chunks", time, free);
qpw->leaf_count, qpw->used_count - qpw->free_count, LOG_STATS(
qpw->used_count, qpw->free_count, qpw->hold_count); "qp marksweep leaf %u live %u used %u free %u hold %u",
qpw->leaf_count, qpw->used_count - qpw->free_count,
qpw->used_count, qpw->free_count, qpw->hold_count);
}
} }
/*********************************************************************** /***********************************************************************