mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-22 01:59:26 +00:00
Code Issues Releases Wiki Activity

Only warn about fixup commits once per run

Browse Source 
The Danger GitLab CI job currently generates a separate error message
about fixup commits being present in a merge request for every such
commit found.  Prevent that by making it only log that error message
once per run.
This commit is contained in:
Michał Kępień 2021-01-18 14:57:47 +01:00
parent 953c810f41
commit 801d13f62f
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dangerfile.py
View File

@ -61,12 +61,16 @@ target_branch = danger.gitlab.mr.target_branch
# four spaces (useful for pasting compiler warnings, static analyzer
# messages, log lines, etc.)
fixup_error_logged = False
for commit in danger.git.commits:
message_lines = commit.message.splitlines()
subject = message_lines[0]
if subject.startswith('fixup!') or subject.startswith('Apply suggestion'):
if (not fixup_error_logged and
(subject.startswith('fixup!') or
subject.startswith('Apply suggestion'))):
fail('Fixup commits are still present in this merge request. '
'Please squash them before merging.')
fixup_error_logged = True
if len(subject) > 72:
warn(
f'Subject line for commit {commit.sha} is too long: '