From 84df920d9e1e256e5132b10db098b1abfdda301e Mon Sep 17 00:00:00 2001
From: Matthijs Mekking <matthijs@isc.org>
Date: Thu, 5 Dec 2024 09:52:38 +0100
Subject: [PATCH] Change default max-recursion-queries to 50

Changing the default for max-recursion-queries from 100 to 32 was too
strict in some cases, especially lookups in reverse IPv6 trees started
to fail more frequently. From issue #4921 it looks like 50 is a better
default.

Now that we have 'max-query-count' as a global limit of outgoing queries
per client request, we can increase the default for
'max-recursion-queries' again, as the number of recursive queries is
no longer bound by the multiple of 'max-recursion-queries' and
'max-query-restarts'.
---
 bin/delv/delv.c       | 2 +-
 bin/delv/delv.rst     | 2 +-
 bin/named/config.c    | 2 +-
 doc/arm/reference.rst | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/bin/delv/delv.c b/bin/delv/delv.c
index 2ecaeb3ed7..3c74195812 100644
--- a/bin/delv/delv.c
+++ b/bin/delv/delv.c
@@ -93,7 +93,7 @@
 
 #define MAXNAME (DNS_NAME_MAXTEXT + 1)
 
-#define MAX_QUERIES  32
+#define MAX_QUERIES  50
 #define MAX_TOTAL    200
 #define MAX_RESTARTS 11
 
diff --git a/bin/delv/delv.rst b/bin/delv/delv.rst
index f8c2da6806..018161ecf1 100644
--- a/bin/delv/delv.rst
+++ b/bin/delv/delv.rst
@@ -351,7 +351,7 @@ assign values to options like the timeout interval. They have the form
 .. option:: +maxqueries
 
    This option specifies the maximum number of queries to send to resolve
-   a name before giving up. The default is 32.
+   a name before giving up. The default is 50.
 
 .. option:: +maxtotalqueries
 
diff --git a/bin/named/config.c b/bin/named/config.c
index 636b3393c2..d4d6b0b4f0 100644
--- a/bin/named/config.c
+++ b/bin/named/config.c
@@ -168,7 +168,7 @@ options {\n\
 	max-clients-per-query 100;\n\
 	max-ncache-ttl 10800; /* 3 hours */\n\
 	max-recursion-depth 7;\n\
-	max-recursion-queries 32;\n\
+	max-recursion-queries 50;\n\
 	max-query-count 200;\n\
 	max-query-restarts 11;\n\
 	max-stale-ttl 86400; /* 1 day */\n\
diff --git a/doc/arm/reference.rst b/doc/arm/reference.rst
index bd3133e142..17f9739dc3 100644
--- a/doc/arm/reference.rst
+++ b/doc/arm/reference.rst
@@ -4501,7 +4501,7 @@ Tuning
    need to be sent before an answer is reached, then recursion is terminated
    and a SERVFAIL response is returned to the client. (Note: if the answer
    is a CNAME, then the subsequent lookup for the target of the CNAME is
-   counted separately.) The default is 32.
+   counted separately.) The default is 50.
 
 .. namedconf:statement:: max-query-restarts
    :tags: server, query