From 8a2ff13c3dbf43c3a3f0ff8f24d9559ec2d72089 Mon Sep 17 00:00:00 2001 From: Mark Andrews Date: Thu, 12 Jun 2014 10:42:39 +1000 Subject: [PATCH] add INSISTs to silence tainted data false positive in Coverity --- lib/dns/rdata/generic/tkey_249.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/dns/rdata/generic/tkey_249.c b/lib/dns/rdata/generic/tkey_249.c index 6f1ec02538..09175615f6 100644 --- a/lib/dns/rdata/generic/tkey_249.c +++ b/lib/dns/rdata/generic/tkey_249.c @@ -465,6 +465,7 @@ tostruct_tkey(ARGS_TOSTRUCT) { /* * Key. */ + INSIST(tkey->keylen + 2 <= sr.length); tkey->key = mem_maybedup(mctx, sr.base, tkey->keylen); if (tkey->key == NULL) goto cleanup; @@ -479,6 +480,7 @@ tostruct_tkey(ARGS_TOSTRUCT) { /* * Other. */ + INSIST(tkey->otherlen <= sr.length); tkey->other = mem_maybedup(mctx, sr.base, tkey->otherlen); if (tkey->other == NULL) goto cleanup;