From 91e5a99b9b10e9cb6904f39a26c47e9dfd39693a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Tue, 12 Mar 2019 08:42:48 +0100 Subject: [PATCH] Silence a Perl warning output by stop.pl On Unix systems, the CYGWIN environment variable is not set at all when BIND system tests are run. If a named instance crashes on shutdown or otherwise fails to clean up its pidfile and the CYGWIN environment variable is not set, stop.pl will print an uninitialized value warning on standard error. Prevent this by using defined(). --- bin/tests/system/stop.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/tests/system/stop.pl b/bin/tests/system/stop.pl index 06ebf61a89..0a1358a275 100644 --- a/bin/tests/system/stop.pl +++ b/bin/tests/system/stop.pl @@ -240,7 +240,7 @@ sub clean_pid_file { if (send_signal(0, $pid) == 0) { # XXX: on windows this is likely to result in a # false positive, so don't bother reporting the error. - if ($ENV{'CYGWIN'} eq "") { + if (!defined($ENV{'CYGWIN'})) { print "I:$test:$server crashed on shutdown\n"; $errors = 1; }