From 953c810f4161f62c36fc463ce973ad8237e74b5b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Mon, 18 Jan 2021 14:57:47 +0100 Subject: [PATCH] Flag trailing dots in commit subject lines Make the Danger GitLab CI job fail when the subject line for any commit belonging to a merge request contains a trailing dot. --- dangerfile.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/dangerfile.py b/dangerfile.py index 7cec7162cc..ad40478f77 100644 --- a/dangerfile.py +++ b/dangerfile.py @@ -43,6 +43,8 @@ target_branch = danger.gitlab.mr.target_branch # # * The subject line starts with "fixup!" or "Apply suggestion". # +# * The subject line contains a trailing dot. +# # * There is no empty line between the subject line and the log message. # # - WARN if any of the following is true for any commit on the MR branch: @@ -70,6 +72,8 @@ for commit in danger.git.commits: f'Subject line for commit {commit.sha} is too long: ' f'```{subject}``` ({len(subject)} > 72 characters).' ) + if subject[-1] == '.': + fail(f'Trailing dot found in the subject of commit {commit.sha}.') if len(message_lines) > 1 and message_lines[1]: fail(f'No empty line after subject for commit {commit.sha}.') if (len(message_lines) < 3 and