mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-29 13:38:26 +00:00
Code Issues Releases Wiki Activity

3761. [bug] Address dangling reference bug in dns_keytable_add.

Browse Source 
[RT #35471]
This commit is contained in:
Mark Andrews 2014-02-27 16:55:46 +11:00
parent 98922b2b2b
commit 96c17c5ecb
2 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGES
View File

@ -1,3 +1,6 @@
3761. [bug] Address dangling reference bug in dns_keytable_add.
[RT #35471]
3760. [bug] Improve SIT with native PKCS#11 and on Windows. 3760. [bug] Improve SIT with native PKCS#11 and on Windows.
[RT #35433] [RT #35433]

3
lib/dns/keytable.c
View File

@ -174,6 +174,7 @@ insert(dns_keytable_t *keytable, isc_boolean_t managed,
for (k = node->data; k != NULL; k = k->next) { for (k = node->data; k != NULL; k = k->next) {
if (k->key == NULL) { if (k->key == NULL) {
k->key = *keyp; k->key = *keyp;
*keyp = NULL; /* transfer ownership */
break; break;
} }
if (dst_key_compare(k->key, *keyp) == ISC_TRUE) if (dst_key_compare(k->key, *keyp) == ISC_TRUE)
@ -182,7 +183,7 @@ insert(dns_keytable_t *keytable, isc_boolean_t managed,
if (k == NULL) if (k == NULL)
result = ISC_R_SUCCESS; result = ISC_R_SUCCESS;
else else if (*keyp != NULL)
dst_key_free(keyp); dst_key_free(keyp);
} }