mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-09-01 06:55:30 +00:00
Code Issues Releases Wiki Activity

3862. [cleanup] Return immediately if we are not going to log the

Browse Source 
message in ns_client_dumpmessage.
This commit is contained in:
Mark Andrews
2014-05-27 12:16:04 +10:00
parent 06ee28c48c
commit 9b819daddf
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGES
View File

@@ -1,3 +1,6 @@
3862. [cleanup] Return immediately if we are not going to log the
message in ns_client_dumpmessage.
3861. [security] Missing isc_buffer_availablelength check results 3861. [security] Missing isc_buffer_availablelength check results
in a REQUIRE assertion when printing out a packet in a REQUIRE assertion when printing out a packet
(CVE-2014-3859). [RT #36078] (CVE-2014-3859). [RT #36078]

3
bin/named/client.c
View File

@@ -3198,6 +3198,9 @@ ns_client_dumpmessage(ns_client_t *client, const char *reason) {
int len = 1024; int len = 1024;
isc_result_t result; isc_result_t result;
if (!isc_log_wouldlog(ns_g_lctx, ISC_LOG_DEBUG(1)))
return;
/* /*
* Note that these are multiline debug messages. We want a newline * Note that these are multiline debug messages. We want a newline
* to appear in the log after each message. * to appear in the log after each message.