mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-09-01 06:55:30 +00:00
Code Issues Releases Wiki Activity

Cleanup left over 'fctx != NULL' test following refactoring

Browse Source 
This was causing 'CID 436299: Null pointer dereferences (REVERSE_INULL)'
in Coverity.  Also removed an 'INSIST(fctx != NULL);' that should
no longer be needed.
This commit is contained in:
Mark Andrews
2023-02-21 13:37:24 +11:00
parent 69b39899d5
commit 9c17f4353b
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/dns/resolver.c
View File

@@ -10613,11 +10613,10 @@ dns_resolver_createfetch(dns_resolver_t *res, const dns_name_t *name,
} }
/* On success, the fctx is locked in get_attached_fctx() */ /* On success, the fctx is locked in get_attached_fctx() */
INSIST(!SHUTTINGDOWN(fctx)); INSIST(!SHUTTINGDOWN(fctx));
/* Is this a duplicate? */ /* Is this a duplicate? */
if (fctx != NULL && client != NULL) { if (client != NULL) {
dns_fetchresponse_t *resp = NULL; dns_fetchresponse_t *resp = NULL;
for (resp = ISC_LIST_HEAD(fctx->resps); resp != NULL; for (resp = ISC_LIST_HEAD(fctx->resps); resp != NULL;
resp = ISC_LIST_NEXT(resp, link)) resp = ISC_LIST_NEXT(resp, link))
@@ -10632,7 +10631,6 @@ dns_resolver_createfetch(dns_resolver_t *res, const dns_name_t *name,
} }
} }
if (count >= spillatmin && spillatmin != 0) { if (count >= spillatmin && spillatmin != 0) {
INSIST(fctx != NULL);
if (count >= spillat) { if (count >= spillat) {
fctx->spilled = true; fctx->spilled = true;
} }