mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-09-01 15:05:23 +00:00
Code Issues Releases Wiki Activity

Silence a scan-build warning in dns_rbt_addname()

Browse Source 
Clang Static Analyzer is unable to grasp that when dns_rbt_addnode()
returns ISC_R_EXISTS, it always sets the pointer passed to it via its
'nodep' parameter to a non-NULL value.  Add an extra safety check in the
conditional expression used in dns_rbt_addname() to silence that
warning.
This commit is contained in:
Michał Kępień
2023-12-22 19:27:37 +01:00
parent 1f78f3a586
commit 9cf1f39b54
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/dns/rbt.c
View File

@@ -733,7 +733,7 @@ dns_rbt_addname(dns_rbt_t *rbt, const dns_name_t *name, void *data) {
* there is data associated with a node. * there is data associated with a node.
*/ */
if (result == ISC_R_SUCCESS || if (result == ISC_R_SUCCESS ||
(result == ISC_R_EXISTS && node->data == NULL)) (result == ISC_R_EXISTS && node != NULL && node->data == NULL))
{ {
node->data = data; node->data = data;
result = ISC_R_SUCCESS; result = ISC_R_SUCCESS;