mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-09-02 07:35:26 +00:00
Code Issues Releases Wiki Activity

Merge branch 'mnowak/try-harder-to-analyze-cores' into 'main'

Browse Source 
Rationalize backtrace logging, fail on core file presence

See merge request isc-projects/bind9!3867
This commit is contained in:
Michal Nowak
2020-07-20 08:13:37 +00:00
parent f27c0c3257 1b13123c45
commit 9dcf229634
1 changed files with 62 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

88
bin/tests/system/run.sh.in
View File

@@ -131,17 +131,13 @@ start_servers() {
fi fi
} }
stop_servers_failed() {
echoinfo "I:$systest:stopping servers failed"
echofail "R:$systest:FAIL"
echoend "E:$systest:$(date_with_args)"
exit 1
}
stop_servers() { stop_servers() {
if $stopservers; then if $stopservers; then
echoinfo "I:$systest:stopping servers" echoinfo "I:$systest:stopping servers"
$PERL stop.pl "$systest" || stop_servers_failed if ! $PERL stop.pl "$systest"; then
echoinfo "I:$systest:stopping servers failed"
return 1
fi
fi fi
} }
@@ -217,7 +213,7 @@ if [ -r "$systest/tests.sh" ]; then
( cd "$systest" && $SHELL tests.sh "$@" ) ( cd "$systest" && $SHELL tests.sh "$@" )
status=$? status=$?
run=$((run+1)) run=$((run+1))
stop_servers stop_servers || status=1
fi fi
if [ -n "$PYTEST" ]; then if [ -n "$PYTEST" ]; then
@@ -232,7 +228,7 @@ if [ -n "$PYTEST" ]; then
test_status=$(cat "$systest/$test.status") test_status=$(cat "$systest/$test.status")
fi fi
status=$((status+test_status)) status=$((status+test_status))
stop_servers stop_servers || status=1
done done
else else
echoinfo "I:$systest:pytest not installed, skipping python tests" echoinfo "I:$systest:pytest not installed, skipping python tests"
@@ -250,55 +246,65 @@ else
exit $status exit $status
fi fi
if [ $status != 0 ]; then get_core_dumps() {
echofail "R:$systest:FAIL" find "$systest/" \( -name 'core*' -or -name '*.core' \) ! -name '*.gz' ! -name '*.txt' | sort
# Do not clean up - we need the evidence. }
else
core_dumps="$(find "$systest/" -name 'core*' -or -name '*.core' | sort | tr '\n' ' ')" core_dumps=$(get_core_dumps | tr '\n' ' ')
assertion_failures=$(find "$systest/" -name named.run -print0 | xargs -0 grep "assertion failure" | wc -l) assertion_failures=$(find "$systest/" -name named.run -print0 | xargs -0 grep "assertion failure" | wc -l)
sanitizer_summaries=$(find "$systest/" -name 'tsan.*' | wc -l) sanitizer_summaries=$(find "$systest/" -name 'tsan.*' | wc -l)
if [ -n "$core_dumps" ]; then if [ -n "$core_dumps" ]; then
echoinfo "I:$systest:Test claims success despite crashes: $core_dumps" status=1
echofail "R:$systest:FAIL" echoinfo "I:$systest:Core dump(s) found: $core_dumps"
# Do not clean up - we need the evidence. get_core_dumps | while read -r coredump; do
find "$systest/" -name 'core*' -or -name '*.core' | while read -r coredump; do
export SYSTESTDIR="$systest" export SYSTESTDIR="$systest"
echoinfo "D:$systest:backtrace from $coredump start" echoinfo "D:$systest:backtrace from $coredump:"
binary=$(gdb --batch --core="$coredump" | sed -ne "s/Core was generated by \`//;s/ .*'.$//p;") echoinfo "D:$systest:--------------------------------------------------------------------------------"
binary=$(gdb --batch --core="$coredump" 2>/dev/null | sed -ne "s/Core was generated by \`//;s/ .*'.$//p;")
"${top_builddir}/libtool" --mode=execute gdb \ "${top_builddir}/libtool" --mode=execute gdb \
--batch \ -batch \
--command=run.gdb \ -ex bt \
--core="$coredump" \ -core="$coredump" \
-- \ -- \
"$binary" "$binary" 2>/dev/null | sed -n '/^Core was generated by/,$p' | cat_d
echoinfo "D:$systest:backtrace from $coredump end" echoinfo "D:$systest:--------------------------------------------------------------------------------"
coredump_backtrace=$(basename "${coredump}")-backtrace.txt
echoinfo "D:$systest:full backtrace from $coredump saved in $coredump_backtrace"
"${top_builddir}/libtool" --mode=execute gdb \
-batch \
-command=run.gdb \
-core="$coredump" \
-- \
"$binary" > "$coredump_backtrace" 2>&1
echoinfo "D:$systest:core dump $coredump archived as $coredump.gz"
gzip -1 "${coredump}"
done done
elif [ "$assertion_failures" -ne 0 ]; then elif [ "$assertion_failures" -ne 0 ]; then
status=1
SYSTESTDIR="$systest" SYSTESTDIR="$systest"
echoinfo "I:$systest:Test claims success despite $assertion_failures assertion failure(s)" echoinfo "I:$systest:$assertion_failures assertion failure(s) found"
find "$systest/" -name 'tsan.*' -print0 | xargs -0 grep "SUMMARY: " | sort -u | cat_d find "$systest/" -name 'tsan.*' -print0 | xargs -0 grep "SUMMARY: " | sort -u | cat_d
elif [ "$sanitizer_summaries" -ne 0 ]; then
status=1
echoinfo "I:$systest:$sanitizer_summaries sanitizer report(s) found"
fi
if [ $status -ne 0 ]; then
echofail "R:$systest:FAIL" echofail "R:$systest:FAIL"
# Do not clean up - we need the evidence. else
elif [ "$sanitizer_summaries" -ne 0 ]; then
echoinfo "I:$systest:Test claims success despite $sanitizer_summaries sanitizer reports(s)"
echofail "R:$systest:FAIL"
else
echopass "R:$systest:PASS" echopass "R:$systest:PASS"
if $clean if $clean; then
then
( cd "${systest}" && $SHELL clean.sh "$@" ) ( cd "${systest}" && $SHELL clean.sh "$@" )
if [ "${srcdir}" != "${builddir}" ]; then if [ "${srcdir}" != "${builddir}" ]; then
rm -rf "./${systest}" ## FIXME (this also removes compiled binaries) rm -rf "./${systest}" ## FIXME (this also removes compiled binaries)
fi fi
if test -d ${srcdir}/../../../.git if test -d ${srcdir}/../../../.git; then
then
git status -su --ignored "${systest}" 2>/dev/null | \ git status -su --ignored "${systest}" 2>/dev/null | \
sed -n -e 's|^?? \(.*\)|I:file \1 not removed|p' \ sed -n -e 's|^?? \(.*\)|I:file \1 not removed|p' \
-e 's|^!! \(.*/named.run\)$|I:file \1 not removed|p' \ -e 's|^!! \(.*/named.run\)$|I:file \1 not removed|p' \
-e 's|^!! \(.*/named.memstats\)$|I:file \1 not removed|p' -e 's|^!! \(.*/named.memstats\)$|I:file \1 not removed|p'
fi fi
fi fi
fi
fi fi
echoend "E:$systest:$(date_with_args)" echoend "E:$systest:$(date_with_args)"