mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-31 06:25:31 +00:00
Code Issues Releases Wiki Activity

code review - minor formatting changes, remove duplicate assignment,

Browse Source 
add a comment to reinspect a loop later
This commit is contained in:
Brian Wellington
2000-03-18 01:00:57 +00:00
parent 71f93ef065
commit 9dee95b41c
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/dns/message.c
View File

@@ -508,7 +508,7 @@ dns_message_create(isc_mem_t *mctx, unsigned int intent, dns_message_t **msgp)
m = isc_mem_get(mctx, sizeof(dns_message_t)); m = isc_mem_get(mctx, sizeof(dns_message_t));
if (m == NULL) if (m == NULL)
return(DNS_R_NOMEMORY); return (DNS_R_NOMEMORY);
/* /*
* No allocations until further notice. Just initialize all lists * No allocations until further notice. Just initialize all lists
@@ -729,9 +729,9 @@ getrdata(dns_name_t *name, isc_buffer_t *source, dns_message_t *msg,
rdata->length = 0; rdata->length = 0;
rdata->rdclass = rdclass; rdata->rdclass = rdclass;
rdata->type = rdtype; rdata->type = rdtype;
return DNS_R_SUCCESS; return (DNS_R_SUCCESS);
} }
scratch = currentbuffer(msg); scratch = currentbuffer(msg);
isc_buffer_setactive(source, rdatalen); isc_buffer_setactive(source, rdatalen);
@@ -746,6 +746,7 @@ getrdata(dns_name_t *name, isc_buffer_t *source, dns_message_t *msg,
*/ */
tries = 0; tries = 0;
trysize = 0; trysize = 0;
/* XXX possibly change this to a while (tries < 2) loop */
for (;;) { for (;;) {
result = dns_rdata_fromwire(rdata, rdclass, rdtype, result = dns_rdata_fromwire(rdata, rdclass, rdtype,
source, dctx, ISC_FALSE, source, dctx, ISC_FALSE,
@@ -862,7 +863,6 @@ getquestions(isc_buffer_t *source, dns_message_t *msg, dns_decompress_t *dctx)
if (msg->state == DNS_SECTION_ANY) { if (msg->state == DNS_SECTION_ANY) {
msg->state = DNS_SECTION_QUESTION; msg->state = DNS_SECTION_QUESTION;
msg->rdclass = rdclass; msg->rdclass = rdclass;
msg->state = DNS_SECTION_QUESTION;
} else if (msg->rdclass != rdclass) { } else if (msg->rdclass != rdclass) {
result = DNS_R_FORMERR; result = DNS_R_FORMERR;
goto cleanup; goto cleanup;
@@ -2192,5 +2192,5 @@ dns_message_checksig(dns_message_t *msg, dns_view_t *view) {
isc_buffer_init(&b, msg->saved->base, msg->saved->length, isc_buffer_init(&b, msg->saved->base, msg->saved->length,
ISC_BUFFERTYPE_BINARY); ISC_BUFFERTYPE_BINARY);
isc_buffer_add(&b, msg->saved->length); isc_buffer_add(&b, msg->saved->length);
return dns_view_checksig(view, &b, msg); return (dns_view_checksig(view, &b, msg));
} }