mirror of
https://gitlab.isc.org/isc-projects/bind9
synced 2025-08-30 22:15:20 +00:00
code review - minor formatting changes, remove duplicate assignment,
add a comment to reinspect a loop later
This commit is contained in:
@@ -729,7 +729,7 @@ getrdata(dns_name_t *name, isc_buffer_t *source, dns_message_t *msg,
|
||||
rdata->length = 0;
|
||||
rdata->rdclass = rdclass;
|
||||
rdata->type = rdtype;
|
||||
return DNS_R_SUCCESS;
|
||||
return (DNS_R_SUCCESS);
|
||||
}
|
||||
|
||||
scratch = currentbuffer(msg);
|
||||
@@ -746,6 +746,7 @@ getrdata(dns_name_t *name, isc_buffer_t *source, dns_message_t *msg,
|
||||
*/
|
||||
tries = 0;
|
||||
trysize = 0;
|
||||
/* XXX possibly change this to a while (tries < 2) loop */
|
||||
for (;;) {
|
||||
result = dns_rdata_fromwire(rdata, rdclass, rdtype,
|
||||
source, dctx, ISC_FALSE,
|
||||
@@ -862,7 +863,6 @@ getquestions(isc_buffer_t *source, dns_message_t *msg, dns_decompress_t *dctx)
|
||||
if (msg->state == DNS_SECTION_ANY) {
|
||||
msg->state = DNS_SECTION_QUESTION;
|
||||
msg->rdclass = rdclass;
|
||||
msg->state = DNS_SECTION_QUESTION;
|
||||
} else if (msg->rdclass != rdclass) {
|
||||
result = DNS_R_FORMERR;
|
||||
goto cleanup;
|
||||
@@ -2192,5 +2192,5 @@ dns_message_checksig(dns_message_t *msg, dns_view_t *view) {
|
||||
isc_buffer_init(&b, msg->saved->base, msg->saved->length,
|
||||
ISC_BUFFERTYPE_BINARY);
|
||||
isc_buffer_add(&b, msg->saved->length);
|
||||
return dns_view_checksig(view, &b, msg);
|
||||
return (dns_view_checksig(view, &b, msg));
|
||||
}
|
||||
|
Reference in New Issue
Block a user