mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-31 22:45:39 +00:00
Code Issues Releases Wiki Activity

Merge branch 'wpk-fix-race-in-rpz-with-min-update-interval-0' into 'master'

Browse Source 
Fix a race in RPZ with min-update-interval set to 0

Closes #643

See merge request isc-projects/bind9!907
This commit is contained in:
Witold Krecicki
2018-10-29 18:12:09 -04:00
parent c3b6eaf3d2 8283cbabdc
commit 9ff13b23f7
2 changed files with 39 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
CHANGES
View File

@@ -1,3 +1,9 @@
5069. [bug] Fix a hang on in RPZ when named is shutdown during RPZ
zone update. [GL !907]
5068. [bug] Fix a race in RPZ with min-update-interval set to 0.
[GL #643]
5067. [bug] Don't minimize qname when sending the query 5067. [bug] Don't minimize qname when sending the query
to a forwarder. [GL #361] to a forwarder. [GL #361]

45
lib/dns/rpz.c
View File

@@ -15,6 +15,7 @@
#include <inttypes.h> #include <inttypes.h>
#include <stdbool.h> #include <stdbool.h>
#include <stdlib.h>
#include <isc/buffer.h> #include <isc/buffer.h>
#include <isc/mem.h> #include <isc/mem.h>
@@ -1802,18 +1803,30 @@ finish_update(dns_rpz_zone_t *rpz) {
* If there's an update pending schedule it * If there's an update pending schedule it
*/ */
if (rpz->updatepending == true) { if (rpz->updatepending == true) {
uint64_t defer = rpz->min_update_interval; if (rpz->min_update_interval > 0) {
isc_interval_t interval; uint64_t defer = rpz->min_update_interval;
dns_name_format(&rpz->origin, dname, isc_interval_t interval;
DNS_NAME_FORMATSIZE); dns_name_format(&rpz->origin, dname,
isc_log_write(dns_lctx, DNS_LOGCATEGORY_GENERAL, DNS_NAME_FORMATSIZE);
DNS_LOGMODULE_MASTER, ISC_LOG_INFO, isc_log_write(dns_lctx, DNS_LOGCATEGORY_GENERAL,
"rpz: %s: new zone version came " DNS_LOGMODULE_MASTER, ISC_LOG_INFO,
"too soon, deferring update for " "rpz: %s: new zone version came "
"%" PRIu64 " seconds", dname, defer); "too soon, deferring update for "
isc_interval_set(&interval, (unsigned int)defer, 0); "%" PRIu64 " seconds", dname, defer);
isc_timer_reset(rpz->updatetimer, isc_timertype_once, isc_interval_set(&interval, (unsigned int)defer, 0);
NULL, &interval, true); isc_timer_reset(rpz->updatetimer, isc_timertype_once,
NULL, &interval, true);
} else {
isc_event_t *event;
INSIST(!ISC_LINK_LINKED(&rpz->updateevent, ev_link));
ISC_EVENT_INIT(&rpz->updateevent,
sizeof(rpz->updateevent), 0, NULL,
DNS_EVENT_RPZUPDATED,
dns_rpz_update_taskaction,
rpz, rpz, NULL, NULL);
event = &rpz->updateevent;
isc_task_send(rpz->rpzs->updater, &event);
}
} }
UNLOCK(&rpz->rpzs->maint_lock); UNLOCK(&rpz->rpzs->maint_lock);
@@ -2100,6 +2113,14 @@ rpz_detach(dns_rpz_zone_t **rpzp, dns_rpz_zones_t *rpzs) {
} }
if (rpz->updaterunning) { if (rpz->updaterunning) {
isc_task_purgeevent(rpz->rpzs->updater, &rpz->updateevent); isc_task_purgeevent(rpz->rpzs->updater, &rpz->updateevent);
if (rpz->updbit != NULL) {
dns_dbiterator_destroy(&rpz->updbit);
}
if (rpz->newnodes != NULL) {
isc_ht_destroy(&rpz->newnodes);
}
dns_db_closeversion(rpz->updb, &rpz->updbversion, false);
dns_db_detach(&rpz->updb);
} }
isc_timer_reset(rpz->updatetimer, isc_timertype_inactive, isc_timer_reset(rpz->updatetimer, isc_timertype_inactive,