mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-31 22:45:39 +00:00
Code Issues Releases Wiki Activity

Remove randomly scattered additional style check suppressions that caused unmatchedSuppression

Browse Source
This commit is contained in:
Ondřej Surý
2019-09-27 12:48:23 +02:00
parent d1f035bbba
commit a0d3614a60
8 changed files with 0 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
lib/dns/ecdb.c
View File

@@ -745,7 +745,6 @@ rdatasetiter_destroy(dns_rdatasetiter_t **iteratorp) {
REQUIRE(iteratorp != NULL); REQUIRE(iteratorp != NULL);
REQUIRE(DNS_RDATASETITER_VALID(*iteratorp)); REQUIRE(DNS_RDATASETITER_VALID(*iteratorp));
/* cppcheck-suppress unreadVariable */
u.rdatasetiterator = *iteratorp; u.rdatasetiterator = *iteratorp;
*iteratorp = NULL; *iteratorp = NULL;

2
lib/dns/openssldh_link.c
View File

@@ -243,7 +243,6 @@ progress_cb(int p, int n, BN_GENCB *cb) {
UNUSED(n); UNUSED(n);
/* cppcheck-suppress unreadVariable */
u.dptr = BN_GENCB_get_arg(cb); u.dptr = BN_GENCB_get_arg(cb);
if (u.fptr != NULL) if (u.fptr != NULL)
u.fptr(p); u.fptr(p);
@@ -304,7 +303,6 @@ openssldh_generate(dst_key_t *key, int generator, void (*callback)(int)) {
if (callback == NULL) { if (callback == NULL) {
BN_GENCB_set_old(cb, NULL, NULL); BN_GENCB_set_old(cb, NULL, NULL);
} else { } else {
/* cppcheck-suppress unreadVariable */
u.fptr = callback; u.fptr = callback;
BN_GENCB_set(cb, progress_cb, u.dptr); BN_GENCB_set(cb, progress_cb, u.dptr);
} }

2
lib/dns/opensslrsa_link.c
View File

@@ -426,7 +426,6 @@ progress_cb(int p, int n, BN_GENCB *cb) {
UNUSED(n); UNUSED(n);
/* cppcheck-suppress unreadVariable */
u.dptr = BN_GENCB_get_arg(cb); u.dptr = BN_GENCB_get_arg(cb);
if (u.fptr != NULL) if (u.fptr != NULL)
u.fptr(p); u.fptr(p);
@@ -495,7 +494,6 @@ opensslrsa_generate(dst_key_t *key, int exp, void (*callback)(int)) {
if (callback == NULL) { if (callback == NULL) {
BN_GENCB_set_old(cb, NULL, NULL); BN_GENCB_set_old(cb, NULL, NULL);
} else { } else {
/* cppcheck-suppress unreadVariable */
u.fptr = callback; u.fptr = callback;
BN_GENCB_set(cb, progress_cb, u.dptr); BN_GENCB_set(cb, progress_cb, u.dptr);
} }

2
lib/dns/rcode.c
View File

@@ -361,7 +361,6 @@ dns_secalg_format(dns_secalg_t alg, char *cp, unsigned int size) {
isc_buffer_usedregion(&b, &r); isc_buffer_usedregion(&b, &r);
r.base[r.length] = 0; r.base[r.length] = 0;
if (result != ISC_R_SUCCESS) { if (result != ISC_R_SUCCESS) {
/* cppcheck-suppress unreadVariable */
r.base[0] = 0; r.base[0] = 0;
} }
} }
@@ -461,7 +460,6 @@ dns_dsdigest_format(dns_dsdigest_t typ, char *cp, unsigned int size) {
isc_buffer_usedregion(&b, &r); isc_buffer_usedregion(&b, &r);
r.base[r.length] = 0; r.base[r.length] = 0;
if (result != ISC_R_SUCCESS) { if (result != ISC_R_SUCCESS) {
/* cppcheck-suppress unreadVariable */
r.base[0] = 0; r.base[0] = 0;
} }
} }

1
lib/dns/ttl.c
View File

@@ -121,7 +121,6 @@ dns_ttl_totext(uint32_t src, bool verbose,
* here because region.base is type unsigned char *. * here because region.base is type unsigned char *.
*/ */
isc_buffer_usedregion(target, &region); isc_buffer_usedregion(target, &region);
/* cppcheck-suppress unreadVariable */
region.base[region.length - 1] = region.base[region.length - 1] =
toupper(region.base[region.length - 1]); toupper(region.base[region.length - 1]);
} }

1
lib/isc/sockaddr.c
View File

@@ -164,7 +164,6 @@ isc_sockaddr_totext(const isc_sockaddr_t *sockaddr, isc_buffer_t *target) {
*/ */
isc_buffer_availableregion(target, &avail); isc_buffer_availableregion(target, &avail);
INSIST(avail.length >= 1); INSIST(avail.length >= 1);
/* cppcheck-suppress unreadVariable */
avail.base[0] = '\0'; avail.base[0] = '\0';
return (ISC_R_SUCCESS); return (ISC_R_SUCCESS);

1
lib/isc/tests/random_test.c
View File

@@ -541,7 +541,6 @@ blockfrequency(isc_mem_t *mctx, uint16_t *values, size_t length) {
/* Preconditions (section 2.2.7 in NIST SP 800-22) */ /* Preconditions (section 2.2.7 in NIST SP 800-22) */
assert_true(numbits >= 100); assert_true(numbits >= 100);
/* cppcheck-suppress constArgument */
assert_true(mbits >= 20); assert_true(mbits >= 20);
assert_true((double) mbits > (0.01 * numbits)); assert_true((double) mbits > (0.01 * numbits));
assert_true(numblocks < 100); assert_true(numblocks < 100);

1
lib/isc/unix/resource.c
View File

@@ -164,7 +164,6 @@ isc_resource_setlimit(isc_resource_t resource, isc_resourcevalue_t value) {
return (ISC_R_SUCCESS); return (ISC_R_SUCCESS);
} }
#endif #endif
/* cppcheck-suppress duplicateCondition */
if (resource == isc_resource_openfiles && rlim_value == RLIM_INFINITY) { if (resource == isc_resource_openfiles && rlim_value == RLIM_INFINITY) {
if (getrlimit(unixresource, &rl) == 0) { if (getrlimit(unixresource, &rl) == 0) {
rl.rlim_cur = rl.rlim_max; rl.rlim_cur = rl.rlim_max;