From d555cb97040a7b2c253c4c11ed822a53c2aff7b7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Sur=C3=BD?= Date: Wed, 2 Jul 2025 18:19:50 +0200 Subject: [PATCH] The nodefullname doesn't need a read lock to access .name The qpznode->name is constant - assigned when the node is created and it is immutable, so there's no reason to have it locked at all. --- lib/dns/qpzone.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/dns/qpzone.c b/lib/dns/qpzone.c index 8e6fa99a39..139e0a1954 100644 --- a/lib/dns/qpzone.c +++ b/lib/dns/qpzone.c @@ -5144,18 +5144,12 @@ qpzone_deleterdataset(dns_db_t *db, dns_dbnode_t *dbnode, static isc_result_t nodefullname(dns_dbnode_t *node, dns_name_t *name) { - qpznode_t *qpnode = (qpznode_t *)node; - isc_rwlocktype_t nlocktype = isc_rwlocktype_none; - isc_rwlock_t *nlock = NULL; - REQUIRE(node != NULL); REQUIRE(name != NULL); - nlock = qpzone_get_lock(qpnode); + qpznode_t *qpnode = (qpznode_t *)node; - NODE_RDLOCK(nlock, &nlocktype); dns_name_copy(&qpnode->name, name); - NODE_UNLOCK(nlock, &nlocktype); return ISC_R_SUCCESS; }