mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-09-01 06:55:30 +00:00
Code Issues Releases Wiki Activity

[master] close() fd when done (Coverity report)

Browse Source
This commit is contained in:
Mukund Sivaraman
2014-11-11 07:14:20 +05:30
parent fadf7291df
commit a3157f3c75
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/isc/tests/file_test.c
View File

@@ -46,6 +46,7 @@ ATF_TC_HEAD(isc_file_sanitize, tc) {
ATF_TC_BODY(isc_file_sanitize, tc) { ATF_TC_BODY(isc_file_sanitize, tc) {
isc_result_t result; isc_result_t result;
char buf[1024]; char buf[1024];
int fd;
ATF_CHECK(chdir(TESTS) != -1); ATF_CHECK(chdir(TESTS) != -1);
@@ -56,15 +57,19 @@ ATF_TC_BODY(isc_file_sanitize, tc) {
ATF_CHECK_EQ(result, ISC_R_SUCCESS); ATF_CHECK_EQ(result, ISC_R_SUCCESS);
ATF_CHECK(strcmp(buf, F(NAME)) == 0); ATF_CHECK(strcmp(buf, F(NAME)) == 0);
ATF_CHECK(creat(F(TRUNC_SHA), 0644) != -1); fd = creat(F(TRUNC_SHA), 0644);
ATF_CHECK(fd != -1);
result = isc_file_sanitize("testdata/file", NAME, "test", buf, 1024); result = isc_file_sanitize("testdata/file", NAME, "test", buf, 1024);
ATF_CHECK_EQ(result, ISC_R_SUCCESS); ATF_CHECK_EQ(result, ISC_R_SUCCESS);
ATF_CHECK(strcmp(buf, F(TRUNC_SHA)) == 0); ATF_CHECK(strcmp(buf, F(TRUNC_SHA)) == 0);
close(fd);
ATF_CHECK(creat(F(SHA), 0644) != -1); fd = creat(F(SHA), 0644);
ATF_CHECK(fd != -1);
result = isc_file_sanitize("testdata/file", NAME, "test", buf, 1024); result = isc_file_sanitize("testdata/file", NAME, "test", buf, 1024);
ATF_CHECK_EQ(result, ISC_R_SUCCESS); ATF_CHECK_EQ(result, ISC_R_SUCCESS);
ATF_CHECK(strcmp(buf, F(SHA)) == 0); ATF_CHECK(strcmp(buf, F(SHA)) == 0);
close(fd);
result = isc_file_sanitize("testdata/file", BAD1, "test", buf, 1024); result = isc_file_sanitize("testdata/file", BAD1, "test", buf, 1024);
ATF_CHECK_EQ(result, ISC_R_SUCCESS); ATF_CHECK_EQ(result, ISC_R_SUCCESS);