mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-09-02 23:55:27 +00:00
Code Issues Releases Wiki Activity

429. [bug] The space reserved for a TSIG record in a response

Browse Source 
was 2 bytes too short, leading to message
                        generation failures.
This commit is contained in:
Brian Wellington
2000-09-07 21:08:52 +00:00
parent 70d950d16e
commit abaec24086
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGES
View File

@@ -1,3 +1,7 @@
429. [bug] The space reserved for a TSIG record in a response
was 2 bytes too short, leading to message
generation failures.
428. [bug] rbtdb.c:find_closest_nxt() erroneously returned 428. [bug] rbtdb.c:find_closest_nxt() erroneously returned
DNS_R_BADDB for nodes which had neither NXT nor SIG NXT DNS_R_BADDB for nodes which had neither NXT nor SIG NXT
(e.g. glue). This could cause SERVFAILs when (e.g. glue). This could cause SERVFAILs when

8
lib/dns/message.c
View File

@@ -15,7 +15,7 @@
* WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. * WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/ */
/* $Id: message.c,v 1.142 2000/08/22 01:10:42 bwelling Exp $ */ /* $Id: message.c,v 1.143 2000/09/07 21:08:51 bwelling Exp $ */
/*** /***
*** Imports *** Imports
@@ -587,6 +587,8 @@ spacefortsig(dns_tsigkey_t *key, int otherlen) {
* 2 bytes for the type * 2 bytes for the type
* 2 bytes for the class * 2 bytes for the class
* 4 bytes for the ttl * 4 bytes for the ttl
* 2 bytes for the rdlength
* n2 bytes for the algorithm name
* 6 bytes for the time signed * 6 bytes for the time signed
* 2 bytes for the fudge * 2 bytes for the fudge
* 2 bytes for the MAC size * 2 bytes for the MAC size
@@ -596,7 +598,7 @@ spacefortsig(dns_tsigkey_t *key, int otherlen) {
* 2 bytes for the other data length * 2 bytes for the other data length
* y bytes for the other data (at most) * y bytes for the other data (at most)
* --------------------------------- * ---------------------------------
* 30 + n1 + n2 + x + y bytes * 26 + n1 + n2 + x + y bytes
*/ */
dns_name_toregion(&key->name, &r1); dns_name_toregion(&key->name, &r1);
@@ -608,7 +610,7 @@ spacefortsig(dns_tsigkey_t *key, int otherlen) {
if (result != ISC_R_SUCCESS) if (result != ISC_R_SUCCESS)
x = 0; x = 0;
} }
return (24 + r1.length + r2.length + x + otherlen); return (26 + r1.length + r2.length + x + otherlen);
} }
isc_result_t isc_result_t