mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-22 18:19:42 +00:00
Code Issues Releases Wiki Activity

Flag new user-visible log messages for review

Browse Source 
Messages with log levels INFO or higher are flagged for manual review.
Purpose of this check is to prevent debug logs to being released with
too-high log level.
This commit is contained in:
Petr Špaček 2022-03-15 11:55:36 +01:00
parent ffc5ab9f5f
commit b0f59cb5cb
No known key found for this signature in database
GPG Key ID: ABD587CDF06581AE
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
dangerfile.py
View File

@ -273,3 +273,24 @@ annotations_added = lines_containing(configure_added_lines, '# [pairwise: ')
if len(switches_added) > len(annotations_added): if len(switches_added) > len(annotations_added):
fail('This merge request adds at least one new `./configure` switch that ' fail('This merge request adds at least one new `./configure` switch that '
'is not annotated for pairwise testing purposes.') 'is not annotated for pairwise testing purposes.')
###############################################################################
# USER-VISIBLE LOG LEVELS
###############################################################################
#
# WARN if the merge request adds new user-visible log messages (INFO or above)
user_visible_log_levels = [
'ISC_LOG_INFO',
'ISC_LOG_NOTICE',
'ISC_LOG_WARNING',
'ISC_LOG_ERROR',
'ISC_LOG_CRITICAL',
]
source_added_lines = added_lines(target_branch, ['*.[ch]'])
for log_level in user_visible_log_levels:
if (lines_containing(source_added_lines, log_level)):
warn('This merge request adds new user-visible log messages with '
'level INFO or above. Please double-check log levels and make '
'sure none of the messages added is a leftover debug message.')
break