From b108376a102325d8992e786567bc2371bc687c9d Mon Sep 17 00:00:00 2001
From: Mark Andrews <marka@isc.org>
Date: Tue, 4 Dec 2018 13:39:00 +1100
Subject: [PATCH] log a error if we don't explicitly know that a error has been
 logged in zone_sign

---
 lib/dns/zone.c | 30 ++++++++++++++++++------------
 1 file changed, 18 insertions(+), 12 deletions(-)

diff --git a/lib/dns/zone.c b/lib/dns/zone.c
index 62c038d4bf..9b1ed96b56 100644
--- a/lib/dns/zone.c
+++ b/lib/dns/zone.c
@@ -8495,11 +8495,11 @@ zone_sign(dns_zone_t *zone) {
 	ISC_LIST_INIT(cleanup);
 
 	/*
-	 * Updates are disabled.  Pause for 5 minutes.
+	 * Updates are disabled.  Pause for 1 minute.
 	 */
 	if (zone->update_disabled) {
 		result = ISC_R_FAILURE;
-		goto failure;
+		goto cleanup;
 	}
 
 	ZONEDB_LOCK(&zone->dblock, isc_rwlocktype_read);
@@ -8508,7 +8508,7 @@ zone_sign(dns_zone_t *zone) {
 	ZONEDB_UNLOCK(&zone->dblock, isc_rwlocktype_read);
 	if (db == NULL) {
 		result = ISC_R_FAILURE;
-		goto failure;
+		goto cleanup;
 	}
 
 	result = dns_db_newversion(db, &version);
@@ -8516,7 +8516,7 @@ zone_sign(dns_zone_t *zone) {
 		dns_zone_log(zone, ISC_LOG_ERROR,
 			     "zone_sign:dns_db_newversion -> %s",
 			     dns_result_totext(result));
-		goto failure;
+		goto cleanup;
 	}
 
 	isc_stdtime_get(&now);
@@ -8527,7 +8527,7 @@ zone_sign(dns_zone_t *zone) {
 		dns_zone_log(zone, ISC_LOG_ERROR,
 			     "zone_sign:dns__zone_findkeys -> %s",
 			     dns_result_totext(result));
-		goto failure;
+		goto cleanup;
 	}
 
 	sigvalidityinterval = dns_zone_getsigvalidityinterval(zone);
@@ -8803,7 +8803,7 @@ zone_sign(dns_zone_t *zone) {
 							     ISC_LOG_ERROR,
 						    "updatesecure -> %s",
 						    dns_result_totext(result));
-						goto failure;
+						goto cleanup;
 					}
 				}
 				result = updatesignwithkey(zone, signing,
@@ -8815,7 +8815,7 @@ zone_sign(dns_zone_t *zone) {
 					dns_zone_log(zone, ISC_LOG_ERROR,
 						     "updatesignwithkey -> %s",
 						     dns_result_totext(result));
-					goto failure;
+					goto cleanup;
 				}
 				build_nsec = false;
 				goto next_signing;
@@ -8823,7 +8823,7 @@ zone_sign(dns_zone_t *zone) {
 				dns_zone_log(zone, ISC_LOG_ERROR,
 					"zone_sign:dns_dbiterator_next -> %s",
 					     dns_result_totext(result));
-				goto failure;
+				goto cleanup;
 			} else if (is_bottom_of_zone) {
 				dns_dbiterator_current(signing->dbiterator,
 						       &node, nextname);
@@ -8851,7 +8851,7 @@ zone_sign(dns_zone_t *zone) {
 			dns_zone_log(zone, ISC_LOG_ERROR, "zone_sign:"
 				     "dns__zone_updatesigs -> %s",
 				     dns_result_totext(result));
-			goto failure;
+			goto cleanup;
 		}
 	}
 
@@ -8873,7 +8873,7 @@ zone_sign(dns_zone_t *zone) {
 		dns_zone_log(zone, ISC_LOG_ERROR,
 			     "zone_sign:del_sigs -> %s",
 			     dns_result_totext(result));
-		goto failure;
+		goto cleanup;
 	}
 
 	result = update_soa_serial(db, version, zonediff.diff, zone->mctx,
@@ -8882,7 +8882,7 @@ zone_sign(dns_zone_t *zone) {
 		dns_zone_log(zone, ISC_LOG_ERROR,
 			     "zone_sign:update_soa_serial -> %s",
 			     dns_result_totext(result));
-		goto failure;
+		goto cleanup;
 	}
 
 	/*
@@ -8896,7 +8896,7 @@ zone_sign(dns_zone_t *zone) {
 		dns_zone_log(zone, ISC_LOG_ERROR,
 			     "zone_sign:add_sigs -> %s",
 			     dns_result_totext(result));
-		goto failure;
+		goto cleanup;
 	}
 
 	/*
@@ -8945,6 +8945,12 @@ zone_sign(dns_zone_t *zone) {
 	}
 
  failure:
+	if (result != ISC_R_SUCCESS) {
+		dns_zone_log(zone, ISC_LOG_ERROR, "zone_sign: failed: %s",
+			     dns_result_totext(result));
+	}
+
+ cleanup:
 	/*
 	 * Pause all dbiterators.
 	 */