From 45377c2e7dda14d88612cb25d81981956b117a5a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Mon, 8 May 2023 15:29:07 +0200 Subject: [PATCH 1/6] Apply minor corrections to CHANGES --- CHANGES | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CHANGES b/CHANGES index eac5a1a7c8..820ed16525 100644 --- a/CHANGES +++ b/CHANGES @@ -22,14 +22,14 @@ 6157. [bug] When removing delegations in an OPTOUT range empty-non-terminal NSEC3 records generated by - those delegations where not removed. [GL #4027] + those delegations were not removed. [GL #4027] 6156. [bug] Reimplement the maximum and idle timeouts for incoming zone tranfers. [GL #4004] 6155. [bug] Treat ISC_R_INVALIDPROTO as a networking error in the dispatch code to avoid retrying with the - same server. [GL #4005]< + same server. [GL #4005] 6154. [func] Add spinlock implementation. The spinlock is much smaller (8 bytes) than pthread_mutex (40 bytes), so From dce2e72f1ee465ccd3a558365b56650f400eeb9f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Mon, 8 May 2023 15:29:07 +0200 Subject: [PATCH 2/6] Prepare release notes for BIND 9.19.13 --- doc/arm/notes.rst | 2 +- .../{notes-current.rst => notes-9.19.13.rst} | 15 --------------- 2 files changed, 1 insertion(+), 16 deletions(-) rename doc/notes/{notes-current.rst => notes-9.19.13.rst} (94%) diff --git a/doc/arm/notes.rst b/doc/arm/notes.rst index c5a6cef2d8..5bf34ee721 100644 --- a/doc/arm/notes.rst +++ b/doc/arm/notes.rst @@ -38,7 +38,7 @@ information about each release, and source code. .. include:: ../notes/notes-known-issues.rst -.. include:: ../notes/notes-current.rst +.. include:: ../notes/notes-9.19.13.rst .. include:: ../notes/notes-9.19.12.rst .. include:: ../notes/notes-9.19.11.rst .. include:: ../notes/notes-9.19.10.rst diff --git a/doc/notes/notes-current.rst b/doc/notes/notes-9.19.13.rst similarity index 94% rename from doc/notes/notes-current.rst rename to doc/notes/notes-9.19.13.rst index e06d042a4c..c48c8eb2f1 100644 --- a/doc/notes/notes-current.rst +++ b/doc/notes/notes-9.19.13.rst @@ -12,27 +12,12 @@ Notes for BIND 9.19.13 ---------------------- -Security Fixes -~~~~~~~~~~~~~~ - -- None. - New Features ~~~~~~~~~~~~ - ``dnstap-read`` can now print long timestamps with millisecond precision. :gl:`#2360` -Removed Features -~~~~~~~~~~~~~~~~ - -- None. - -Feature Changes -~~~~~~~~~~~~~~~ - -- None. - Bug Fixes ~~~~~~~~~ From 893cf037f3b63992d4838f132d8adf82f2677d8a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Mon, 8 May 2023 15:29:07 +0200 Subject: [PATCH 3/6] Tweak and reword release notes --- doc/notes/notes-9.19.13.rst | 42 ++++++++++++++++++++----------------- 1 file changed, 23 insertions(+), 19 deletions(-) diff --git a/doc/notes/notes-9.19.13.rst b/doc/notes/notes-9.19.13.rst index c48c8eb2f1..19a6703fb1 100644 --- a/doc/notes/notes-9.19.13.rst +++ b/doc/notes/notes-9.19.13.rst @@ -15,35 +15,39 @@ Notes for BIND 9.19.13 New Features ~~~~~~~~~~~~ -- ``dnstap-read`` can now print long timestamps with millisecond precision. - :gl:`#2360` +- :iscman:`dnstap-read` can now print long timestamps with millisecond + precision. :gl:`#2360` Bug Fixes ~~~~~~~~~ -- When the same ``notify-source`` address and port number was configured for - multiple destinations and zones, an unresponsive server could tie up the - socket until it timed out; in the meantime, NOTIFY messages for other servers - silently failed.``named`` will now retry these failing messages over TCP. - NOTIFY failures are now logged at level INFO. :gl:`#4001` :gl:`#4002` +- When the same :any:`notify-source` address and port number was + configured for multiple destinations and zones, an unresponsive server + could tie up the relevant network socket until it timed out; in the + meantime, NOTIFY messages for other servers silently failed. + :iscman:`named` will now retry sending such NOTIFY messages over TCP. + Furthermore, NOTIFY failures are now logged at the INFO level. + :gl:`#4001` :gl:`#4002` -- When ISC_R_INVALIDPROTO (ENOPROTOOPT, EPROTONOSUPPORT) is returned from - libuv, treat it as a network failure, mark the server as broken and don't - try again. :gl:`#4005` +- When the ``ISC_R_INVALIDPROTO`` (``ENOPROTOOPT``, ``EPROTONOSUPPORT``) + error code is returned by libuv, it is now treated as a network + failure: the server for which that error code is returned gets marked + as broken and is not contacted again during a given resolution + process. :gl:`#4005` -- The :any:`max-transfer-time-in` and :any:`max-transfer-idle-in` options - were not implemented when the BIND 9 networking stack was refactored - in 9.16. The missing functionality has been re-implemented and +- The :any:`max-transfer-time-in` and :any:`max-transfer-idle-in` have + not had any effect since the BIND 9 networking stack was refactored in + version 9.16. The missing functionality has been re-implemented and incoming zone transfers now time out properly when not progressing. :gl:`#4004` -- Log file rotation did not clean up older versions of log files when the - logging :any:`channel` configured an absolute path as ``file`` destination. - This has now been fixed. :gl:`#3991`. +- Log file rotation code did not clean up older versions of log files + when the logging :any:`channel` had an absolute path configured as a + ``file`` destination. This has been fixed. :gl:`#3991` -- The read timeout in ``rndc`` is now 60 seconds, matching the behavior - in BIND 9.16 and earlier. It had previously been lowered to 30 seconds - by mistake. :gl:`#4046` +- The read timeout in :iscman:`rndc` is now 60 seconds, matching the + behavior in BIND 9.16 and earlier. It had previously been lowered to + 30 seconds by mistake. :gl:`#4046` Known Issues ~~~~~~~~~~~~ From ce43231b9c178a3fd69a826354008d44efde073a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Mon, 8 May 2023 15:29:07 +0200 Subject: [PATCH 4/6] Reorder release notes --- doc/notes/notes-9.19.13.rst | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/doc/notes/notes-9.19.13.rst b/doc/notes/notes-9.19.13.rst index 19a6703fb1..ef3499beac 100644 --- a/doc/notes/notes-9.19.13.rst +++ b/doc/notes/notes-9.19.13.rst @@ -29,26 +29,26 @@ Bug Fixes Furthermore, NOTIFY failures are now logged at the INFO level. :gl:`#4001` :gl:`#4002` -- When the ``ISC_R_INVALIDPROTO`` (``ENOPROTOOPT``, ``EPROTONOSUPPORT``) - error code is returned by libuv, it is now treated as a network - failure: the server for which that error code is returned gets marked - as broken and is not contacted again during a given resolution - process. :gl:`#4005` - - The :any:`max-transfer-time-in` and :any:`max-transfer-idle-in` have not had any effect since the BIND 9 networking stack was refactored in version 9.16. The missing functionality has been re-implemented and incoming zone transfers now time out properly when not progressing. :gl:`#4004` -- Log file rotation code did not clean up older versions of log files - when the logging :any:`channel` had an absolute path configured as a - ``file`` destination. This has been fixed. :gl:`#3991` - - The read timeout in :iscman:`rndc` is now 60 seconds, matching the behavior in BIND 9.16 and earlier. It had previously been lowered to 30 seconds by mistake. :gl:`#4046` +- When the ``ISC_R_INVALIDPROTO`` (``ENOPROTOOPT``, ``EPROTONOSUPPORT``) + error code is returned by libuv, it is now treated as a network + failure: the server for which that error code is returned gets marked + as broken and is not contacted again during a given resolution + process. :gl:`#4005` + +- Log file rotation code did not clean up older versions of log files + when the logging :any:`channel` had an absolute path configured as a + ``file`` destination. This has been fixed. :gl:`#3991` + Known Issues ~~~~~~~~~~~~ From d01834466d496f9c477d892b52c53b0ffbebe4f4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Mon, 8 May 2023 15:29:07 +0200 Subject: [PATCH 5/6] Add release note for GL #3985 --- doc/notes/notes-9.19.13.rst | 5 +++++ doc/notes/notes-known-issues.rst | 5 ----- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/notes/notes-9.19.13.rst b/doc/notes/notes-9.19.13.rst index ef3499beac..2565c37a59 100644 --- a/doc/notes/notes-9.19.13.rst +++ b/doc/notes/notes-9.19.13.rst @@ -45,6 +45,11 @@ Bug Fixes as broken and is not contacted again during a given resolution process. :gl:`#4005` +- A flaw in reworked code responsible for accepting TCP connections has + been addressed. This issue could cause a visible performance drop for + TCP queries on some platforms, notably FreeBSD, and has now been + fixed. :gl:`#3985` + - Log file rotation code did not clean up older versions of log files when the logging :any:`channel` had an absolute path configured as a ``file`` destination. This has been fixed. :gl:`#3991` diff --git a/doc/notes/notes-known-issues.rst b/doc/notes/notes-known-issues.rst index 959c73d1d0..d71ff3341c 100644 --- a/doc/notes/notes-known-issues.rst +++ b/doc/notes/notes-known-issues.rst @@ -44,8 +44,3 @@ Known Issues structure being used for storing information about the zones to serve. This slowdown is considered to be a bug and will be addressed in a future BIND 9.19.x development release. :gl:`#4006` - -- A flaw in reworked code responsible for accepting TCP connections may - cause a visible performance drop for TCP queries on some platforms, - notably FreeBSD. This issue will be fixed in a future BIND 9.19.x - development release. :gl:`#3985` From 677fc2257bf408dfbd9e11fd6544888d0eb826ab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Mon, 8 May 2023 15:29:07 +0200 Subject: [PATCH 6/6] Add release note for GL #4027 --- doc/notes/notes-9.19.13.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/doc/notes/notes-9.19.13.rst b/doc/notes/notes-9.19.13.rst index 2565c37a59..a88b3179c3 100644 --- a/doc/notes/notes-9.19.13.rst +++ b/doc/notes/notes-9.19.13.rst @@ -45,6 +45,10 @@ Bug Fixes as broken and is not contacted again during a given resolution process. :gl:`#4005` +- When removing delegations from an opt-out range, empty-non-terminal + NSEC3 records generated by those delegations were not cleaned up. This + has been fixed. :gl:`#4027` + - A flaw in reworked code responsible for accepting TCP connections has been addressed. This issue could cause a visible performance drop for TCP queries on some platforms, notably FreeBSD, and has now been