mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-09-01 06:55:30 +00:00
Code Issues Releases Wiki Activity

1214. [bug] Win32: isc_file_renameunique() could leave zero length

Browse Source 
files behind.
This commit is contained in:
Mark Andrews
2002-02-28 00:23:34 +00:00
parent 9e6286de2a
commit b9c80c8bdd
2 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
CHANGES
View File

@@ -1,3 +1,9 @@
1214. [bug] Win32: isc_file_renameunique() could leave zero length
files behind.
1213. [func] Report view associated with client if it is not a
standard view (_default or _bind).
1212. [port] libbind: 64k answer buffers were causing stack space 1212. [port] libbind: 64k answer buffers were causing stack space
to be exceeded for certian OS. Use heap space instead. to be exceeded for certian OS. Use heap space instead.

6
lib/isc/win32/file.c
View File

@@ -15,7 +15,7 @@
* WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. * WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/ */
/* $Id: file.c,v 1.27 2001/10/01 20:58:51 gson Exp $ */ /* $Id: file.c,v 1.28 2002/02/28 00:23:34 marka Exp $ */
#include <config.h> #include <config.h>
@@ -301,6 +301,8 @@ isc_file_renameunique(const char *file, char *templet) {
fd = mkstemp(templet); fd = mkstemp(templet);
if (fd == -1) if (fd == -1)
result = isc__errno2result(errno); result = isc__errno2result(errno);
else
close(fd);
if (result == ISC_R_SUCCESS) { if (result == ISC_R_SUCCESS) {
res = isc_file_safemovefile(file, templet); res = isc_file_safemovefile(file, templet);
@@ -309,8 +311,6 @@ isc_file_renameunique(const char *file, char *templet) {
(void)unlink(templet); (void)unlink(templet);
} }
} }
if (fd != -1)
close(fd);
return (result); return (result);
} }