mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-09-01 06:55:30 +00:00
Code Issues Releases Wiki Activity

Use a non-atomic counter when passing to stats dumper

Browse Source
This commit is contained in:
Aydın Mercan
2023-12-11 13:50:45 +03:00
committed by Petr Špaček
parent b57c37d8c5
commit bb96142a17
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/isc/stats.c
View File

@@ -29,6 +29,16 @@
typedef atomic_int_fast64_t isc__atomic_statcounter_t; typedef atomic_int_fast64_t isc__atomic_statcounter_t;
/*
* Statistics are counted with an atomic int_fast64_t but exported to functions
* taking int64_t (isc_stats_dumper_t). A 128-bit native and fast architecture
* doesn't exist in reality so these two are the same thing in practise.
* However, a silent truncation happening silently in the future is still not
* acceptable.
*/
STATIC_ASSERT(sizeof(isc__atomic_statcounter_t) <= sizeof(int64_t),
"Exported statistics must fit into the statistic counter size");
struct isc_stats { struct isc_stats {
unsigned int magic; unsigned int magic;
isc_mem_t *mctx; isc_mem_t *mctx;
@@ -116,7 +126,7 @@ isc_stats_dump(isc_stats_t *stats, isc_stats_dumper_t dump_fn, void *arg,
REQUIRE(ISC_STATS_VALID(stats)); REQUIRE(ISC_STATS_VALID(stats));
for (i = 0; i < stats->ncounters; i++) { for (i = 0; i < stats->ncounters; i++) {
isc__atomic_statcounter_t counter = atomic_load_acquire(&stats->counters[i]); int_fast64_t counter = atomic_load_acquire(&stats->counters[i]);
if ((options & ISC_STATSDUMP_VERBOSE) == 0 && counter == 0) { if ((options & ISC_STATSDUMP_VERBOSE) == 0 && counter == 0) {
continue; continue;
} }