mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-31 06:25:31 +00:00
Code Issues Releases Wiki Activity

2148. [func] Add positive logging for rndc commands. [RT #14623]

Browse Source
This commit is contained in:
Mark Andrews
2007-02-26 02:19:45 +00:00
parent 0deee29113
commit bde20a0436
3 changed files with 95 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGES
View File

@@ -1,3 +1,5 @@
2148. [func] Add positive logging for rndc commands. [RT #14623]
2147. [bug] libbind: remove potential buffer overflow from 2147. [bug] libbind: remove potential buffer overflow from
hmac_link.c. [RT #16437] hmac_link.c. [RT #16437]

19
bin/named/control.c
View File

@@ -15,7 +15,7 @@
* PERFORMANCE OF THIS SOFTWARE. * PERFORMANCE OF THIS SOFTWARE.
*/ */
/* $Id: control.c,v 1.29 2006/12/04 01:52:45 marka Exp $ */ /* $Id: control.c,v 1.30 2007/02/26 02:19:45 marka Exp $ */
/*! \file */ /*! \file */
@@ -63,6 +63,7 @@ ns_control_docommand(isccc_sexpr_t *message, isc_buffer_t *text) {
isccc_sexpr_t *data; isccc_sexpr_t *data;
char *command; char *command;
isc_result_t result; isc_result_t result;
int log_level;
#ifdef HAVE_LIBSCF #ifdef HAVE_LIBSCF
ns_smf_want_disable = 0; ns_smf_want_disable = 0;
#endif #endif
@@ -83,14 +84,20 @@ ns_control_docommand(isccc_sexpr_t *message, isc_buffer_t *text) {
return (result); return (result);
} }
isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
NS_LOGMODULE_CONTROL, ISC_LOG_DEBUG(1),
"received control channel command '%s'",
command);
/* /*
* Compare the 'command' parameter against all known control commands. * Compare the 'command' parameter against all known control commands.
*/ */
if (command_compare(command, NS_COMMAND_NULL) ||
command_compare(command, NS_COMMAND_STATUS)) {
log_level = ISC_LOG_DEBUG(1);
} else {
log_level = ISC_LOG_INFO;
}
isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
NS_LOGMODULE_CONTROL, log_level,
"received control channel command '%s'",
command);
if (command_compare(command, NS_COMMAND_RELOAD)) { if (command_compare(command, NS_COMMAND_RELOAD)) {
result = ns_server_reloadcommand(ns_g_server, command, text); result = ns_server_reloadcommand(ns_g_server, command, text);
} else if (command_compare(command, NS_COMMAND_RECONFIG)) { } else if (command_compare(command, NS_COMMAND_RECONFIG)) {

94
bin/named/server.c
View File

@@ -15,7 +15,7 @@
* PERFORMANCE OF THIS SOFTWARE. * PERFORMANCE OF THIS SOFTWARE.
*/ */
/* $Id: server.c,v 1.477 2007/02/13 02:49:08 marka Exp $ */ /* $Id: server.c,v 1.478 2007/02/26 02:19:45 marka Exp $ */
/*! \file */ /*! \file */
@@ -3967,13 +3967,17 @@ loadconfig(ns_server_t *server) {
result = load_configuration(ns_g_lwresdonly ? result = load_configuration(ns_g_lwresdonly ?
lwresd_g_conffile : ns_g_conffile, lwresd_g_conffile : ns_g_conffile,
server, ISC_FALSE); server, ISC_FALSE);
if (result == ISC_R_SUCCESS) if (result == ISC_R_SUCCESS) {
end_reserved_dispatches(server, ISC_FALSE); end_reserved_dispatches(server, ISC_FALSE);
else isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
NS_LOGMODULE_SERVER, ISC_LOG_INFO,
"reloading configuration succeeded");
} else {
isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL, isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
NS_LOGMODULE_SERVER, ISC_LOG_ERROR, NS_LOGMODULE_SERVER, ISC_LOG_ERROR,
"reloading configuration failed: %s", "reloading configuration failed: %s",
isc_result_totext(result)); isc_result_totext(result));
}
return (result); return (result);
} }
@@ -3983,12 +3987,15 @@ reload(ns_server_t *server) {
CHECK(loadconfig(server)); CHECK(loadconfig(server));
result = load_zones(server, ISC_FALSE); result = load_zones(server, ISC_FALSE);
if (result != ISC_R_SUCCESS) { if (result == ISC_R_SUCCESS)
isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
NS_LOGMODULE_SERVER, ISC_LOG_INFO,
"reloading zones succeeded");
else
isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL, isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
NS_LOGMODULE_SERVER, ISC_LOG_ERROR, NS_LOGMODULE_SERVER, ISC_LOG_ERROR,
"reloading zones failed: %s", "reloading zones failed: %s",
isc_result_totext(result)); isc_result_totext(result));
}
cleanup: cleanup:
return (result); return (result);
@@ -4000,12 +4007,15 @@ reconfig(ns_server_t *server) {
CHECK(loadconfig(server)); CHECK(loadconfig(server));
result = load_new_zones(server, ISC_FALSE); result = load_new_zones(server, ISC_FALSE);
if (result != ISC_R_SUCCESS) { if (result == ISC_R_SUCCESS)
isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
NS_LOGMODULE_SERVER, ISC_LOG_INFO,
"any newly configured zones are now loaded");
else
isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL, isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
NS_LOGMODULE_SERVER, ISC_LOG_ERROR, NS_LOGMODULE_SERVER, ISC_LOG_ERROR,
"loading new zones failed: %s", "loading new zones failed: %s",
isc_result_totext(result)); isc_result_totext(result));
}
cleanup: ; cleanup: ;
} }
@@ -4020,6 +4030,9 @@ ns_server_reload(isc_task_t *task, isc_event_t *event) {
INSIST(task = server->task); INSIST(task = server->task);
UNUSED(task); UNUSED(task);
isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
NS_LOGMODULE_SERVER, ISC_LOG_INFO,
"received SIGHUP signal to reload zones");
(void)reload(server); (void)reload(server);
LOCK(&server->reload_event_lock); LOCK(&server->reload_event_lock);
@@ -4412,6 +4425,15 @@ ns_server_dumpstats(ns_server_t *server) {
cleanup: cleanup:
if (fp != NULL) if (fp != NULL)
(void)isc_stdio_close(fp); (void)isc_stdio_close(fp);
if (result == ISC_R_SUCCESS)
isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
NS_LOGMODULE_SERVER, ISC_LOG_INFO,
"dumpstats complete");
else
isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
NS_LOGMODULE_SERVER, ISC_LOG_ERROR,
"dumpstats failed: %s",
dns_result_totext(result));
return (result); return (result);
} }
@@ -4596,7 +4618,7 @@ dumpdone(void *arg, isc_result_t result) {
cleanup: cleanup:
if (result != ISC_R_SUCCESS) if (result != ISC_R_SUCCESS)
isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL, isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
NS_LOGMODULE_SERVER, ISC_LOG_INFO, NS_LOGMODULE_SERVER, ISC_LOG_ERROR,
"dumpdb failed: %s", dns_result_totext(result)); "dumpdb failed: %s", dns_result_totext(result));
dumpcontext_destroy(dctx); dumpcontext_destroy(dctx);
} }
@@ -4693,6 +4715,15 @@ ns_server_dumprecursing(ns_server_t *server) {
cleanup: cleanup:
if (fp != NULL) if (fp != NULL)
result = isc_stdio_close(fp); result = isc_stdio_close(fp);
if (result == ISC_R_SUCCESS)
isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
NS_LOGMODULE_SERVER, ISC_LOG_INFO,
"dumprecursing complete");
else
isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
NS_LOGMODULE_SERVER, ISC_LOG_ERROR,
"dumprecursing failed: %s",
dns_result_totext(result));
return (result); return (result);
} }
@@ -4722,6 +4753,9 @@ ns_server_setdebuglevel(ns_server_t *server, char *args) {
ns_g_debuglevel = (unsigned int)newlevel; ns_g_debuglevel = (unsigned int)newlevel;
} }
isc_log_setdebuglevel(ns_g_lctx, ns_g_debuglevel); isc_log_setdebuglevel(ns_g_lctx, ns_g_debuglevel);
isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
NS_LOGMODULE_SERVER, ISC_LOG_INFO,
"debug level is now %d", ns_g_debuglevel);
return (ISC_R_SUCCESS); return (ISC_R_SUCCESS);
} }
@@ -4802,14 +4836,29 @@ ns_server_flushcache(ns_server_t *server, char *args) {
if (viewname != NULL && strcasecmp(viewname, view->name) != 0) if (viewname != NULL && strcasecmp(viewname, view->name) != 0)
continue; continue;
result = dns_view_flushcache(view); result = dns_view_flushcache(view);
if (result != ISC_R_SUCCESS) if (result != ISC_R_SUCCESS) {
isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
NS_LOGMODULE_SERVER, ISC_LOG_ERROR,
"flushing cache in view '%s' failed: %s",
view->name, isc_result_totext(result));
goto out; goto out;
}
flushed = ISC_TRUE; flushed = ISC_TRUE;
} }
if (flushed) if (flushed) {
if (viewname != NULL)
isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
NS_LOGMODULE_SERVER, ISC_LOG_INFO,
"flushing cache in view '%s' succeeded",
viewname);
else
isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
NS_LOGMODULE_SERVER, ISC_LOG_INFO,
"flushing caches in all views succeeded");
result = ISC_R_SUCCESS; result = ISC_R_SUCCESS;
else } else {
result = ISC_R_FAILURE; result = ISC_R_FAILURE;
}
out: out:
isc_task_endexclusive(server->task); isc_task_endexclusive(server->task);
return (result); return (result);
@@ -4856,13 +4905,30 @@ ns_server_flushname(ns_server_t *server, char *args) {
if (viewname != NULL && strcasecmp(viewname, view->name) != 0) if (viewname != NULL && strcasecmp(viewname, view->name) != 0)
continue; continue;
result = dns_view_flushname(view, name); result = dns_view_flushname(view, name);
if (result != ISC_R_SUCCESS) if (result != ISC_R_SUCCESS) {
flushed = ISC_FALSE; flushed = ISC_FALSE;
isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
NS_LOGMODULE_SERVER, ISC_LOG_ERROR,
"flushing name '%s' in cache view '%s' "
"failed: %s", target, view->name,
isc_result_totext(result));
}
} }
if (flushed) if (flushed) {
if (viewname != NULL)
isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
NS_LOGMODULE_SERVER, ISC_LOG_INFO,
"flushing name '%s' in cache view '%s' "
"succeeded", target, viewname);
else
isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
NS_LOGMODULE_SERVER, ISC_LOG_INFO,
"flushing name '%s' in all cache views "
"succeeded", target);
result = ISC_R_SUCCESS; result = ISC_R_SUCCESS;
else } else {
result = ISC_R_FAILURE; result = ISC_R_FAILURE;
}
isc_task_endexclusive(server->task); isc_task_endexclusive(server->task);
return (result); return (result);
} }