From c19ebde14bb64739d01670170f76d2cc3d2e2a29 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= Date: Mon, 29 Jul 2019 21:44:31 +0200 Subject: [PATCH] Make root hints consistent with authoritative data Resolvers in the "filter-aaaa" system test are configured with a single root hint: "ns.rootservers.net", pointing to 10.53.0.1. However, querying ns1 for "ns.rootservers.net" results in NXDOMAIN answers. Since the TTL for the root hint is set to 0, it may happen that a resolver's ADB will be asked to return any known addresses for "ns.rootservers.net", but it will only have access to a cached NXDOMAIN answer for that name and an expired root hint, which will result in a resolution failure, triggering a false positive for the "filter-aaaa" system test. Prevent this from happening by making all the root hints consistent with authoritative data served by ns1. --- bin/tests/system/filter-aaaa/ns2/hints | 7 +++++-- bin/tests/system/filter-aaaa/ns3/hints | 7 +++++-- bin/tests/system/filter-aaaa/ns5/hints | 7 +++++-- 3 files changed, 15 insertions(+), 6 deletions(-) diff --git a/bin/tests/system/filter-aaaa/ns2/hints b/bin/tests/system/filter-aaaa/ns2/hints index 381e86b152..fbf01a9369 100644 --- a/bin/tests/system/filter-aaaa/ns2/hints +++ b/bin/tests/system/filter-aaaa/ns2/hints @@ -7,5 +7,8 @@ ; See the COPYRIGHT file distributed with this work for additional ; information regarding copyright ownership. -. 0 NS ns.rootservers.utld. -ns.rootservers.utld. 0 A 10.53.0.1 +$TTL 120 + +. NS ns.utld. +ns.utld. A 10.53.0.1 +ns.utld. AAAA fd92:7065:b8e:ffff::1 diff --git a/bin/tests/system/filter-aaaa/ns3/hints b/bin/tests/system/filter-aaaa/ns3/hints index 381e86b152..fbf01a9369 100644 --- a/bin/tests/system/filter-aaaa/ns3/hints +++ b/bin/tests/system/filter-aaaa/ns3/hints @@ -7,5 +7,8 @@ ; See the COPYRIGHT file distributed with this work for additional ; information regarding copyright ownership. -. 0 NS ns.rootservers.utld. -ns.rootservers.utld. 0 A 10.53.0.1 +$TTL 120 + +. NS ns.utld. +ns.utld. A 10.53.0.1 +ns.utld. AAAA fd92:7065:b8e:ffff::1 diff --git a/bin/tests/system/filter-aaaa/ns5/hints b/bin/tests/system/filter-aaaa/ns5/hints index 381e86b152..fbf01a9369 100644 --- a/bin/tests/system/filter-aaaa/ns5/hints +++ b/bin/tests/system/filter-aaaa/ns5/hints @@ -7,5 +7,8 @@ ; See the COPYRIGHT file distributed with this work for additional ; information regarding copyright ownership. -. 0 NS ns.rootservers.utld. -ns.rootservers.utld. 0 A 10.53.0.1 +$TTL 120 + +. NS ns.utld. +ns.utld. A 10.53.0.1 +ns.utld. AAAA fd92:7065:b8e:ffff::1