2
0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-29 21:47:59 +00:00

more code review

This commit is contained in:
Brian Wellington 2000-03-16 02:08:51 +00:00
parent 96805adfc9
commit c363150ad5
3 changed files with 34 additions and 34 deletions

View File

@ -15,7 +15,7 @@
* SOFTWARE. * SOFTWARE.
*/ */
/* $Id: isdn_20.c,v 1.13 2000/03/16 00:54:24 bwelling Exp $ */ /* $Id: isdn_20.c,v 1.14 2000/03/16 02:08:49 bwelling Exp $ */
/* Reviewed: Wed Mar 15 16:53:11 PST 2000 by bwelling */ /* Reviewed: Wed Mar 15 16:53:11 PST 2000 by bwelling */
@ -31,9 +31,9 @@ fromtext_isdn(dns_rdataclass_t rdclass, dns_rdatatype_t type,
{ {
isc_token_t token; isc_token_t token;
rdclass = rdclass; /*unused*/ UNUSED(rdclass);
origin = origin; /*unused*/ UNUSED(origin);
downcase = downcase; /*unused*/ UNUSED(downcase);
REQUIRE(type == 20); REQUIRE(type == 20);
@ -57,7 +57,7 @@ totext_isdn(dns_rdata_t *rdata, dns_rdata_textctx_t *tctx,
{ {
isc_region_t region; isc_region_t region;
tctx = tctx; /*unused*/ UNUSED(tctx);
REQUIRE(rdata->type == 20); REQUIRE(rdata->type == 20);
@ -74,9 +74,9 @@ fromwire_isdn(dns_rdataclass_t rdclass, dns_rdatatype_t type,
isc_buffer_t *source, dns_decompress_t *dctx, isc_buffer_t *source, dns_decompress_t *dctx,
isc_boolean_t downcase, isc_buffer_t *target) isc_boolean_t downcase, isc_buffer_t *target)
{ {
dctx = dctx; /* unused */ UNUSED(dctx);
rdclass = rdclass; /* unused */ UNUSED(rdclass);
downcase = downcase; /* unused */ UNUSED(downcase);
REQUIRE(type == 20); REQUIRE(type == 20);
@ -88,7 +88,7 @@ fromwire_isdn(dns_rdataclass_t rdclass, dns_rdatatype_t type,
static inline isc_result_t static inline isc_result_t
towire_isdn(dns_rdata_t *rdata, dns_compress_t *cctx, isc_buffer_t *target) { towire_isdn(dns_rdata_t *rdata, dns_compress_t *cctx, isc_buffer_t *target) {
cctx = cctx; /*unused*/ UNUSED(cctx);
REQUIRE(rdata->type == 20); REQUIRE(rdata->type == 20);
@ -113,9 +113,9 @@ static inline isc_result_t
fromstruct_isdn(dns_rdataclass_t rdclass, dns_rdatatype_t type, void *source, fromstruct_isdn(dns_rdataclass_t rdclass, dns_rdatatype_t type, void *source,
isc_buffer_t *target) isc_buffer_t *target)
{ {
rdclass = rdclass; /*unused*/ UNUSED(rdclass);
source = source; /*unused*/ UNUSED(source);
target = target; /*unused*/ UNUSED(target);
REQUIRE(type == 20); REQUIRE(type == 20);
@ -124,8 +124,8 @@ fromstruct_isdn(dns_rdataclass_t rdclass, dns_rdatatype_t type, void *source,
static inline isc_result_t static inline isc_result_t
tostruct_isdn(dns_rdata_t *rdata, void *target, isc_mem_t *mctx) { tostruct_isdn(dns_rdata_t *rdata, void *target, isc_mem_t *mctx) {
target = target; /*unused*/ UNUSED(target);
mctx = mctx; /*unused*/ UNUSED(mctx);
REQUIRE(rdata->type == 20); REQUIRE(rdata->type == 20);
@ -142,8 +142,8 @@ static inline isc_result_t
additionaldata_isdn(dns_rdata_t *rdata, dns_additionaldatafunc_t add, additionaldata_isdn(dns_rdata_t *rdata, dns_additionaldatafunc_t add,
void *arg) void *arg)
{ {
add = add; /*unused*/ UNUSED(add);
arg = arg; /*unused*/ UNUSED(arg);
REQUIRE(rdata->type == 20); REQUIRE(rdata->type == 20);

View File

@ -15,7 +15,7 @@
* SOFTWARE. * SOFTWARE.
*/ */
/* $Id: mb_7.c,v 1.21 2000/03/16 01:26:49 bwelling Exp $ */ /* $Id: mb_7.c,v 1.22 2000/03/16 02:08:50 bwelling Exp $ */
/* Reviewed: Wed Mar 15 17:31:26 PST 2000 by bwelling */ /* Reviewed: Wed Mar 15 17:31:26 PST 2000 by bwelling */
@ -31,7 +31,7 @@ fromtext_mb(dns_rdataclass_t rdclass, dns_rdatatype_t type,
dns_name_t name; dns_name_t name;
isc_buffer_t buffer; isc_buffer_t buffer;
rdclass = rdclass; /*unused*/ UNUSED(rdclass);
REQUIRE(type == 7); REQUIRE(type == 7);
@ -73,7 +73,7 @@ fromwire_mb(dns_rdataclass_t rdclass, dns_rdatatype_t type,
{ {
dns_name_t name; dns_name_t name;
rdclass = rdclass; /*unused*/ UNUSED(rdclass);
REQUIRE(type == 7); REQUIRE(type == 7);
@ -132,9 +132,9 @@ static inline isc_result_t
fromstruct_mb(dns_rdataclass_t rdclass, dns_rdatatype_t type, void *source, fromstruct_mb(dns_rdataclass_t rdclass, dns_rdatatype_t type, void *source,
isc_buffer_t *target) isc_buffer_t *target)
{ {
rdclass = rdclass; /*unused*/ UNUSED(rdclass);
source = source; /*unused*/ UNUSED(source);
target = target; /*unused*/ UNUSED(target);
REQUIRE(type == 7); REQUIRE(type == 7);
@ -143,8 +143,8 @@ fromstruct_mb(dns_rdataclass_t rdclass, dns_rdatatype_t type, void *source,
static inline isc_result_t static inline isc_result_t
tostruct_mb(dns_rdata_t *rdata, void *target, isc_mem_t *mctx) { tostruct_mb(dns_rdata_t *rdata, void *target, isc_mem_t *mctx) {
target = target; /*unused*/ UNUSED(target);
mctx = mctx; /*unused*/ UNUSED(mctx);
REQUIRE(rdata->type == 7); REQUIRE(rdata->type == 7);

View File

@ -15,7 +15,7 @@
* SOFTWARE. * SOFTWARE.
*/ */
/* $Id: md_3.c,v 1.22 2000/03/16 01:44:08 bwelling Exp $ */ /* $Id: md_3.c,v 1.23 2000/03/16 02:08:51 bwelling Exp $ */
/* Reviewed: Wed Mar 15 17:48:20 PST 2000 by bwelling */ /* Reviewed: Wed Mar 15 17:48:20 PST 2000 by bwelling */
@ -31,7 +31,7 @@ fromtext_md(dns_rdataclass_t rdclass, dns_rdatatype_t type,
dns_name_t name; dns_name_t name;
isc_buffer_t buffer; isc_buffer_t buffer;
rdclass = rdclass; /*unused*/ UNUSED(rdclass);
REQUIRE(type == 3); REQUIRE(type == 3);
@ -73,7 +73,7 @@ fromwire_md(dns_rdataclass_t rdclass, dns_rdatatype_t type,
{ {
dns_name_t name; dns_name_t name;
rdclass = rdclass; /*unused*/ UNUSED(rdclass);
REQUIRE(type == 3); REQUIRE(type == 3);
@ -132,9 +132,9 @@ static inline isc_result_t
fromstruct_md(dns_rdataclass_t rdclass, dns_rdatatype_t type, void *source, fromstruct_md(dns_rdataclass_t rdclass, dns_rdatatype_t type, void *source,
isc_buffer_t *target) isc_buffer_t *target)
{ {
rdclass = rdclass; /*unused*/ UNUSED(rdclass);
source = source; /*unused*/ UNUSED(source);
target = target; /*unused*/ UNUSED(target);
REQUIRE(type == 3); REQUIRE(type == 3);
@ -143,8 +143,8 @@ fromstruct_md(dns_rdataclass_t rdclass, dns_rdatatype_t type, void *source,
static inline isc_result_t static inline isc_result_t
tostruct_md(dns_rdata_t *rdata, void *target, isc_mem_t *mctx) { tostruct_md(dns_rdata_t *rdata, void *target, isc_mem_t *mctx) {
target = target; /*unused*/ UNUSED(target);
mctx = mctx; /*unused*/ UNUSED(mctx);
REQUIRE(rdata->type == 3); REQUIRE(rdata->type == 3);