mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-29 13:38:26 +00:00
Code Issues Releases Wiki Activity

netmgr: log TCP connection errors

Browse Source
This commit is contained in:
Evan Hunt 2019-11-21 18:38:04 -08:00
parent 0260d31d26
commit c4ad0466d6
3 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/isc/include/isc/log.h
View File

@ -177,7 +177,8 @@ LIBISC_EXTERNAL_DATA extern isc_logmodule_t isc_modules[];
#define ISC_LOGMODULE_INTERFACE (&isc_modules[2]) #define ISC_LOGMODULE_INTERFACE (&isc_modules[2])
#define ISC_LOGMODULE_TIMER (&isc_modules[3]) #define ISC_LOGMODULE_TIMER (&isc_modules[3])
#define ISC_LOGMODULE_FILE (&isc_modules[4]) #define ISC_LOGMODULE_FILE (&isc_modules[4])
#define ISC_LOGMODULE_OTHER (&isc_modules[5]) #define ISC_LOGMODULE_NETMGR (&isc_modules[5])
#define ISC_LOGMODULE_OTHER (&isc_modules[6])
ISC_LANG_BEGINDECLS ISC_LANG_BEGINDECLS

1
lib/isc/log.c
View File

@ -192,6 +192,7 @@ LIBISC_EXTERNAL_DATA isc_logmodule_t isc_modules[] = {
{ "interface", 0 }, { "interface", 0 },
{ "timer", 0 }, { "timer", 0 },
{ "file", 0 }, { "file", 0 },
{ "netmgr", 0 },
{ "other", 0 }, { "other", 0 },
{ NULL, 0 } { NULL, 0 }
}; };

9
lib/isc/netmgr/tcp.c
View File

@ -15,6 +15,7 @@
#include <isc/atomic.h> #include <isc/atomic.h>
#include <isc/buffer.h> #include <isc/buffer.h>
#include <isc/condition.h> #include <isc/condition.h>
#include <isc/log.h>
#include <isc/magic.h> #include <isc/magic.h>
#include <isc/mem.h> #include <isc/mem.h>
#include <isc/netmgr.h> #include <isc/netmgr.h>
@ -500,15 +501,19 @@ accept_connection(isc_nmsocket_t *ssock) {
static void static void
tcp_connection_cb(uv_stream_t *server, int status) { tcp_connection_cb(uv_stream_t *server, int status) {
isc_nmsocket_t *ssock = server->data; isc_nmsocket_t *ssock = server->data;
isc_result_t result = accept_connection(ssock); isc_result_t result;
UNUSED(status); UNUSED(status);
result = accept_connection(ssock);
if (result != ISC_R_SUCCESS) { if (result != ISC_R_SUCCESS) {
if (result == ISC_R_QUOTA || result == ISC_R_SOFTQUOTA) { if (result == ISC_R_QUOTA || result == ISC_R_SOFTQUOTA) {
ssock->overquota = true; ssock->overquota = true;
} }
/* TODO: Log the error. */ isc_log_write(isc_lctx, ISC_LOGCATEGORY_GENERAL,
ISC_LOGMODULE_NETMGR, ISC_LOG_ERROR,
"TCP connection failed: %s",
isc_result_totext(result));
} }
} }