mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-22 01:59:26 +00:00
Code Issues Releases Wiki Activity

Check meson pairwise testing switches

Browse Source 
dangerfile.py checked for new configure switches in `configure.ac`,
these were annotated with "# [pairwise:..." in a leading line. Meson
reads those from `meson_options.txt` instead.
This commit is contained in:
Andoni Duarte Pintado 2025-06-30 13:14:33 +02:00 committed by Andoni Duarte
parent 367889e080
commit c4c14f0f23
1 changed files with 9 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
dangerfile.py
View File

@ -406,26 +406,16 @@ if mr_title_action == "sec" and (mr_title_cve is None or "CVE-20" not in mr_titl
# PAIRWISE TESTING
###############################################################################
#
# FAIL if the merge request adds any new ./configure switch without an
# associated annotation used for pairwise testing.
# MESSAGE about pairwise-testing any new build options before merging.
configure_added_lines = added_lines(target_branch, ["configure.ac"])
switches_added = lines_containing(
configure_added_lines, "AC_ARG_ENABLE"
) + lines_containing(configure_added_lines, "AC_ARG_WITH")
annotations_added = lines_containing(configure_added_lines, "# [pairwise: ")
meson_added_lines = added_lines(target_branch, ["meson_options.txt"])
switches_added = lines_containing(meson_added_lines, "option(")
if switches_added:
if len(switches_added) > len(annotations_added):
fail(
"This merge request adds at least one new `./configure` switch that "
"is not annotated for pairwise testing purposes."
)
else:
message(
"**Before merging**, please start a full CI pipeline for this "
"branch with the `PAIRWISE_TESTING` variable set to any "
"non-empty value (e.g. `1`). This will cause the `pairwise` "
"job to exercise the new `./configure` switches."
"job to exercise the new build options added by this merge request."
)
###############################################################################