mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-28 21:17:54 +00:00
Code Issues Releases Wiki Activity

3656. [bug] Treat a all zero netmask as invalid when generating

Browse Source 
the localnets acl. [RT #34687]
This commit is contained in:
Mark Andrews 2013-09-26 07:40:34 +10:00
parent fb623f9a07
commit c9ee72cb3a
2 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGES
View File

@ -1,3 +1,6 @@
3656. [bug] Treat a all zero netmask as invalid when generating
the localnets acl. [RT #34687]
3655. [cleanup] Simplify TCP message processing when requesting a 3655. [cleanup] Simplify TCP message processing when requesting a
zone transfer. [RT #34825] zone transfer. [RT #34825]

15
bin/named/interfacemgr.c
View File

@ -564,15 +564,22 @@ setup_locals(ns_interfacemgr_t *mgr, isc_interface_t *interface) {
return (result); return (result);
if (result != ISC_R_SUCCESS) { if (result != ISC_R_SUCCESS) {
isc_log_write(IFMGR_COMMON_LOGARGS, isc_log_write(IFMGR_COMMON_LOGARGS, ISC_LOG_WARNING,
ISC_LOG_WARNING,
"omitting IPv4 interface %s from " "omitting IPv4 interface %s from "
"localnets ACL: %s", "localnets ACL: %s", interface->name,
interface->name,
isc_result_totext(result)); isc_result_totext(result));
return (ISC_R_SUCCESS); return (ISC_R_SUCCESS);
} }
if (prefixlen == 0U) {
isc_log_write(IFMGR_COMMON_LOGARGS, ISC_LOG_WARNING,
"omitting %s interface %s from localnets ACL: "
"zero prefix length detected",
(netaddr->family == AF_INET) ? "IPv4" : "IPv6",
interface->name);
return (ISC_R_SUCCESS);
}
result = dns_iptable_addprefix(mgr->aclenv.localnets->iptable, result = dns_iptable_addprefix(mgr->aclenv.localnets->iptable,
netaddr, prefixlen, ISC_TRUE); netaddr, prefixlen, ISC_TRUE);
if (result != ISC_R_SUCCESS) if (result != ISC_R_SUCCESS)