mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-09-03 16:15:27 +00:00
Code Issues Releases Wiki Activity

clean up; add warnings about use of signal and broadcast

Browse Source
This commit is contained in:
Bob Halley
1998-10-23 18:22:22 +00:00
parent 9fbefe0ace
commit ce1e4ac907
1 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
lib/isc/win32/condition.c
View File

@@ -32,10 +32,14 @@ isc_condition_init(isc_condition_t *cond) {
isc_result_t isc_result_t
isc_condition_signal(isc_condition_t *cond) { isc_condition_signal(isc_condition_t *cond) {
/*
* Unlike pthreads, the caller MUST hold the lock associated with
* the condition variable when calling us.
*/
REQUIRE(cond != NULL); REQUIRE(cond != NULL);
if (cond->waiters > 0 && if (cond->waiters > 0 &&
!SetEvent(cond->events[SIGNAL])) { !SetEvent(cond->events[SIGNAL])) {
/* XXX */ /* XXX */
return (ISC_R_UNEXPECTED); return (ISC_R_UNEXPECTED);
} }
@@ -46,10 +50,14 @@ isc_condition_signal(isc_condition_t *cond) {
isc_result_t isc_result_t
isc_condition_broadcast(isc_condition_t *cond) { isc_condition_broadcast(isc_condition_t *cond) {
/*
* Unlike pthreads, the caller MUST hold the lock associated with
* the condition variable when calling us.
*/
REQUIRE(cond != NULL); REQUIRE(cond != NULL);
if (cond->waiters > 0 && if (cond->waiters > 0 &&
!SetEvent(cond->events[BROADCAST])) { !SetEvent(cond->events[BROADCAST])) {
/* XXX */ /* XXX */
return (ISC_R_UNEXPECTED); return (ISC_R_UNEXPECTED);
} }
@@ -68,8 +76,7 @@ isc_condition_destroy(isc_condition_t *cond) {
return (ISC_R_SUCCESS); return (ISC_R_SUCCESS);
} }
static static isc_result_t
isc_result_t
wait(isc_condition_t *cond, isc_mutex_t *mutex, DWORD milliseconds) { wait(isc_condition_t *cond, isc_mutex_t *mutex, DWORD milliseconds) {
DWORD result; DWORD result;
@@ -83,7 +90,7 @@ wait(isc_condition_t *cond, isc_mutex_t *mutex, DWORD milliseconds) {
EnterCriticalSection(mutex); EnterCriticalSection(mutex);
cond->waiters--; cond->waiters--;
if (cond->waiters == 0 && if (cond->waiters == 0 &&
!ResetEvent(cond->events[BROADCAST])) { !ResetEvent(cond->events[BROADCAST])) {
/* XXX */ /* XXX */
LeaveCriticalSection(mutex); LeaveCriticalSection(mutex);
return (ISC_R_UNEXPECTED); return (ISC_R_UNEXPECTED);