From e4654d1a6a657faf13bfee2bc53aace2f718b3d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ondr=CC=8Cej=20Sury=CC=81?= Date: Thu, 10 Nov 2022 16:34:26 +0100 Subject: [PATCH 1/2] Bump the allowed HTTP headers in statschannel to 100 Firefox 90+ apparently sends more than 10 headers, so we need to bump the number to some higher number. Bump it to 100 just to be on a save side, this is for internal use only anyway. --- lib/isc/httpd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/isc/httpd.c b/lib/isc/httpd.c index aee63f8a93..c91847088d 100644 --- a/lib/isc/httpd.c +++ b/lib/isc/httpd.c @@ -51,7 +51,7 @@ */ #define HTTP_RECVLEN ISC_NETMGR_TCP_RECVBUF_SIZE * 2 #define HTTP_SENDLEN ISC_NETMGR_TCP_RECVBUF_SIZE -#define HTTP_HEADERS_NUM 10 +#define HTTP_HEADERS_NUM 100 #define HTTP_MAX_REQUEST_LEN 4096 #define HTTPD_CLOSE 0x0001 /* Got a Connection: close header */ From c65666dc9742a34395d53bb251df217a2feec56e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ondr=CC=8Cej=20Sury=CC=81?= Date: Thu, 10 Nov 2022 16:41:25 +0100 Subject: [PATCH 2/2] Add CHANGES and release note for [GL #3670] --- CHANGES | 4 ++++ doc/notes/notes-current.rst | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/CHANGES b/CHANGES index 50bc9dcf5c..3c00f7e1cf 100644 --- a/CHANGES +++ b/CHANGES @@ -1,3 +1,7 @@ +6015. [bug] Some browsers (Firefox) send more than 10 HTTP + headers. Bump the number of allowed HTTP headers + to 100. [GL #3670] + 6014. [func] Add isc_hashmap API implementation that implements Robin Hood hashing. The API requires the keys to be stored with the stored value. [GL !6790] diff --git a/doc/notes/notes-current.rst b/doc/notes/notes-current.rst index 6be7563b9e..b689ac2d9c 100644 --- a/doc/notes/notes-current.rst +++ b/doc/notes/notes-current.rst @@ -35,7 +35,9 @@ Feature Changes Bug Fixes ~~~~~~~~~ -- None. +- Increase the number of HTTP headers in the statistics channel from + 10 to 100 to accomodate for some browsers that send more that 10 + headers by default. :gl:`#3670` Known Issues ~~~~~~~~~~~~