From dbca22877ab2c6d98a2eacf963b66c097fc1fcfb Mon Sep 17 00:00:00 2001 From: Artem Boldariev Date: Wed, 28 Jul 2021 19:30:30 +0300 Subject: [PATCH] Limit the number of requests sent per connection in DoH tests This commit ensures that only a limited number of requests is going to be sent over a single HTTP/2 connection. Before that change was introduced, it was possible to complete all of the planned sends via only one transport connection, which undermines the purpose of the tests using the quota facility. --- lib/isc/tests/doh_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/isc/tests/doh_test.c b/lib/isc/tests/doh_test.c index 198c7bfc23..e4f59ce7fd 100644 --- a/lib/isc/tests/doh_test.c +++ b/lib/isc/tests/doh_test.c @@ -725,7 +725,7 @@ doh_receive_send_reply_cb(isc_nmhandle_t *handle, isc_result_t eresult, int_fast64_t sends = atomic_fetch_sub(&nsends, 1); atomic_fetch_add(&csends, 1); atomic_fetch_add(&creads, 1); - if (sends > 0) { + if (sends > 0 && cbarg == NULL) { size_t i; for (i = 0; i < NWRITES / 2; i++) { eresult = isc__nm_http_request( @@ -733,7 +733,7 @@ doh_receive_send_reply_cb(isc_nmhandle_t *handle, isc_result_t eresult, &(isc_region_t){ .base = (uint8_t *)send_msg.base, .length = send_msg.len }, - doh_receive_send_reply_cb, cbarg); + doh_receive_send_reply_cb, (void *)1); if (eresult == ISC_R_CANCELED) { break; }