mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-31 22:45:39 +00:00
Code Issues Releases Wiki Activity

don't use strlcat with non NUL terminated strings rt45981_stage3

Browse Source
This commit is contained in:
Mark Andrews
2017-09-15 13:14:16 +10:00
parent bdd3edceb9
commit dc71aa898a
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/dns/rcode.c
View File

@@ -252,8 +252,8 @@ maybe_numeric(unsigned int *valuep, isc_textregion_t *source,
* isc_parse_uint32(). isc_parse_uint32() requires
* null termination, so we must make a copy.
*/
strlcpy(buffer, source->base,
ISC_MIN(source->length + 1, sizeof(buffer)));
snprintf(buffer, sizeof(buffer), "%.*s",
(int)source->length, source->base);
INSIST(buffer[source->length] == '\0');
@@ -508,8 +508,8 @@ dns_rdataclass_fromtext(dns_rdataclass_t *classp, isc_textregion_t *source) {
* source->base is not required to be NUL terminated.
* Copy up to remaining bytes and NUL terminate.
*/
strlcpy(buf, source->base + 5,
ISC_MIN(source->length - 5 + 1, sizeof(buf)));
snprintf(buf, sizeof(buf), "%.*s",
(int)(source->length - 5), source->base + 5);
val = strtoul(buf, &endp, 10);
if (*endp == '\0' && val <= 0xffff) {
*classp = (dns_rdataclass_t)val;