mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-31 22:45:39 +00:00
Code Issues Releases Wiki Activity

comment the fact that cview may be NULL in configure_view;

Browse Source 
avoid NULL reference when reporting the (probably impossible) error of
the default view missing root hints
This commit is contained in:
Andreas Gustafsson
2000-04-07 17:08:12 +00:00
parent 8f9f5011b0
commit dded22b184
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
bin/named/server.c
View File

@@ -156,7 +156,11 @@ configure_view_acl(dns_c_view_t *cview,
} }
/* /*
* Configure 'view' according to 'cctx'. * Configure 'view' according to 'cview', taking defaults from 'cctx'
* where values are missing in cctx.
*
* When configuring the default view, cctx will be NULL and the
* glboal defaults in cview used exclusively.
*/ */
static isc_result_t static isc_result_t
configure_view(dns_view_t *view, dns_c_ctx_t *cctx, dns_c_view_t *cview, configure_view(dns_view_t *view, dns_c_ctx_t *cctx, dns_c_view_t *cview,
@@ -289,7 +293,8 @@ configure_view(dns_view_t *view, dns_c_ctx_t *cctx, dns_c_view_t *cview,
if (view->hints == NULL) { if (view->hints == NULL) {
isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL, isc_log_write(ns_g_lctx, NS_LOGCATEGORY_GENERAL,
NS_LOGMODULE_SERVER, ISC_LOG_ERROR, NS_LOGMODULE_SERVER, ISC_LOG_ERROR,
"no root hints for view '%s'", cview->name); "no root hints for view '%s'",
cview == NULL ? "<default>" : cview->name);
result = ISC_R_FAILURE; result = ISC_R_FAILURE;
goto cleanup; goto cleanup;
} }