mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-09-01 15:05:23 +00:00
Code Issues Releases Wiki Activity

[master] dig/mdig could send misformatted ECS options

Browse Source 
4307.	[bug]		"dig +subnet" and "mdig +subnet" could send
			incorrectly-formatted Client Subnet options
			if the prefix length was not divisble by 8.
			Also fixed a memory leak in "mdig". [RT #45178]
This commit is contained in:
Evan Hunt
2016-01-29 17:41:29 -08:00
parent 7e5658b04f
commit df9a49ee07
4 changed files with 79 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
CHANGES
View File

@@ -1,3 +1,8 @@
4307. [bug] "dig +subnet" and "mdig +subnet" could send
incorrectly-formatted Client Subnet options
if the prefix length was not divisble by 8.
Also fixed a memory leak in "mdig". [RT #45178]
4306. [maint] Added a PKCS#11 openssl patch supporting 4306. [maint] Added a PKCS#11 openssl patch supporting
version 1.0.2f [RT #38312] version 1.0.2f [RT #38312]

57
bin/dig/dighost.c
View File

@@ -1104,7 +1104,7 @@ parse_netprefix(isc_sockaddr_t **sap, const char *value) {
} else if (netmask != 0xffffffff) { } else if (netmask != 0xffffffff) {
int i; int i;
for (i = 0; i < 3; i++) { for (i = 0; i < 3 && strlen(buf) < sizeof(buf) - 2; i++) {
strlcat(buf, ".0", sizeof(buf)); strlcat(buf, ".0", sizeof(buf));
if (inet_pton(AF_INET, buf, &in4) == 1) { if (inet_pton(AF_INET, buf, &in4) == 1) {
parsed = ISC_TRUE; parsed = ISC_TRUE;
@@ -2504,23 +2504,18 @@ setup_lookup(dig_lookup_t *lookup) {
} }
if (lookup->ecs_addr != NULL) { if (lookup->ecs_addr != NULL) {
isc_uint32_t prefixlen; isc_uint8_t addr[16], family;
isc_uint32_t plen;
struct sockaddr *sa; struct sockaddr *sa;
struct sockaddr_in *sin; struct sockaddr_in *sin;
struct sockaddr_in6 *sin6; struct sockaddr_in6 *sin6;
const isc_uint8_t *addr;
size_t addrl; size_t addrl;
isc_uint8_t mask;
sa = &lookup->ecs_addr->type.sa; sa = &lookup->ecs_addr->type.sa;
prefixlen = lookup->ecs_addr->length; plen = lookup->ecs_addr->length;
/* Round up prefix len to a multiple of 8 */ /* Round up prefix len to a multiple of 8 */
addrl = (prefixlen + 7) / 8; addrl = (plen + 7) / 8;
if (prefixlen % 8 == 0)
mask = 0xff;
else
mask = 0xffU << (8 - (prefixlen % 8));
INSIST(i < DNS_EDNSOPTIONS); INSIST(i < DNS_EDNSOPTIONS);
opts[i].code = DNS_OPT_CLIENT_SUBNET; opts[i].code = DNS_OPT_CLIENT_SUBNET;
@@ -2528,40 +2523,32 @@ setup_lookup(dig_lookup_t *lookup) {
check_result(result, "isc_buffer_allocate"); check_result(result, "isc_buffer_allocate");
isc_buffer_init(&b, ecsbuf, sizeof(ecsbuf)); isc_buffer_init(&b, ecsbuf, sizeof(ecsbuf));
if (sa->sa_family == AF_INET) { if (sa->sa_family == AF_INET) {
family = 1;
sin = (struct sockaddr_in *) sa; sin = (struct sockaddr_in *) sa;
addr = (isc_uint8_t *) &sin->sin_addr; memcpy(addr, &sin->sin_addr, 4);
/* family */ if ((plen % 8) != 0)
isc_buffer_putuint16(&b, 1); addr[addrl-1] &=
/* source prefix-length */ ~0 << (8 - (plen % 8));
isc_buffer_putuint8(&b, prefixlen);
/* scope prefix-length */
isc_buffer_putuint8(&b, 0);
/* address */
if (addrl > 0) {
isc_buffer_putmem(&b, addr,
(unsigned)addrl - 1);
isc_buffer_putuint8(&b,
(addr[addrl - 1] &
mask));
}
} else { } else {
family = 2;
sin6 = (struct sockaddr_in6 *) sa; sin6 = (struct sockaddr_in6 *) sa;
addr = (isc_uint8_t *) &sin6->sin6_addr; memcpy(addr, &sin6->sin6_addr, 16);
}
/* Mask off last address byte */
if (addrl > 0 && (plen % 8) != 0)
addr[addrl - 1] &= ~0 << (8 - (plen % 8));
/* family */ /* family */
isc_buffer_putuint16(&b, 2); isc_buffer_putuint16(&b, family);
/* source prefix-length */ /* source prefix-length */
isc_buffer_putuint8(&b, prefixlen); isc_buffer_putuint8(&b, plen);
/* scope prefix-length */ /* scope prefix-length */
isc_buffer_putuint8(&b, 0); isc_buffer_putuint8(&b, 0);
/* address */ /* address */
if (addrl > 0) { if (addrl > 0)
isc_buffer_putmem(&b, addr, isc_buffer_putmem(&b, addr,
(unsigned)addrl - 1); (unsigned)addrl);
isc_buffer_putuint8(&b,
(addr[addrl - 1] &
mask));
}
}
opts[i].value = (isc_uint8_t *) ecsbuf; opts[i].value = (isc_uint8_t *) ecsbuf;
i++; i++;

11
bin/tests/system/digdelv/tests.sh
View File

@@ -275,6 +275,17 @@ if [ -x ${DIG} ] ; then
if [ $ret != 0 ]; then echo "I:failed"; fi if [ $ret != 0 ]; then echo "I:failed"; fi
status=`expr $status + $ret` status=`expr $status + $ret`
n=`expr $n + 1`
echo "I:checking dig +subnet with prefix lengths between byte boundaries ($n)"
ret=0
for p in 9 10 11 12 13 14 15; do
$DIG $DIGOPTS +tcp @10.53.0.2 +subnet=10.53/$p A a.example > dig.out.test.$p.$n 2>&1 || ret=1
grep "FORMERR" < dig.out.test.$p.$n > /dev/null && ret=1
grep "CLIENT-SUBNET.*/$p/0" < dig.out.test.$p.$n > /dev/null || ret=1
done
if [ $ret != 0 ]; then echo "I:failed"; fi
status=`expr $status + $ret`
n=`expr $n + 1` n=`expr $n + 1`
echo "I:checking dig +sp works as an abbriviated form of split ($n)" echo "I:checking dig +sp works as an abbriviated form of split ($n)"
ret=0 ret=0

69
bin/tools/mdig.c
View File

@@ -584,24 +584,19 @@ sendquery(struct query *query, isc_task_t *task)
} }
if (query->ecs_addr != NULL) { if (query->ecs_addr != NULL) {
isc_uint32_t prefixlen; isc_uint8_t addr[16], family;
isc_uint32_t plen;
struct sockaddr *sa; struct sockaddr *sa;
struct sockaddr_in *sin; struct sockaddr_in *sin;
struct sockaddr_in6 *sin6; struct sockaddr_in6 *sin6;
const isc_uint8_t *addr;
size_t addrl; size_t addrl;
isc_uint8_t mask;
isc_buffer_t b; isc_buffer_t b;
sa = &query->ecs_addr->type.sa; sa = &query->ecs_addr->type.sa;
prefixlen = query->ecs_addr->length; plen = query->ecs_addr->length;
/* Round up prefix len to a multiple of 8 */ /* Round up prefix len to a multiple of 8 */
addrl = (prefixlen + 7) / 8; addrl = (plen + 7) / 8;
if (prefixlen % 8 == 0)
mask = 0xff;
else
mask = 0xffU << (8 - (prefixlen % 8));
INSIST(i < DNS_EDNSOPTIONS); INSIST(i < DNS_EDNSOPTIONS);
opts[i].code = DNS_OPT_CLIENT_SUBNET; opts[i].code = DNS_OPT_CLIENT_SUBNET;
@@ -609,40 +604,32 @@ sendquery(struct query *query, isc_task_t *task)
CHECK("isc_buffer_allocate", result); CHECK("isc_buffer_allocate", result);
isc_buffer_init(&b, ecsbuf, sizeof(ecsbuf)); isc_buffer_init(&b, ecsbuf, sizeof(ecsbuf));
if (sa->sa_family == AF_INET) { if (sa->sa_family == AF_INET) {
family = 1;
sin = (struct sockaddr_in *) sa; sin = (struct sockaddr_in *) sa;
addr = (isc_uint8_t *) &sin->sin_addr; memcpy(addr, &sin->sin_addr, 4);
/* family */ if ((plen % 8) != 0)
isc_buffer_putuint16(&b, 1); addr[addrl-1] &=
/* source prefix-length */ ~0 << (8 - (plen % 8));
isc_buffer_putuint8(&b, prefixlen);
/* scope prefix-length */
isc_buffer_putuint8(&b, 0);
/* address */
if (addrl > 0) {
isc_buffer_putmem(&b, addr,
(unsigned)addrl - 1);
isc_buffer_putuint8(&b,
(addr[addrl - 1] &
mask));
}
} else { } else {
family = 2;
sin6 = (struct sockaddr_in6 *) sa; sin6 = (struct sockaddr_in6 *) sa;
addr = (isc_uint8_t *) &sin6->sin6_addr; memcpy(addr, &sin6->sin6_addr, 16);
}
/* Mask off last address byte */
if (addrl > 0 && (plen % 8) != 0)
addr[addrl - 1] &= ~0 << (8 - (plen % 8));
/* family */ /* family */
isc_buffer_putuint16(&b, 2); isc_buffer_putuint16(&b, family);
/* source prefix-length */ /* source prefix-length */
isc_buffer_putuint8(&b, prefixlen); isc_buffer_putuint8(&b, plen);
/* scope prefix-length */ /* scope prefix-length */
isc_buffer_putuint8(&b, 0); isc_buffer_putuint8(&b, 0);
/* address */ /* address */
if (addrl > 0) { if (addrl > 0)
isc_buffer_putmem(&b, addr, isc_buffer_putmem(&b, addr,
(unsigned)addrl - 1); (unsigned)addrl);
isc_buffer_putuint8(&b,
(addr[addrl - 1] &
mask));
}
}
opts[i].value = (isc_uint8_t *) ecsbuf; opts[i].value = (isc_uint8_t *) ecsbuf;
i++; i++;
@@ -913,6 +900,7 @@ parse_netprefix(isc_sockaddr_t **sap, const char *value) {
slash = strchr(buf, '/'); slash = strchr(buf, '/');
if (slash != NULL) { if (slash != NULL) {
*slash = '\0';
result = isc_parse_uint32(&netmask, slash + 1, 10); result = isc_parse_uint32(&netmask, slash + 1, 10);
if (result != ISC_R_SUCCESS) { if (result != ISC_R_SUCCESS) {
fatal("invalid prefix length in '%s': %s\n", fatal("invalid prefix length in '%s': %s\n",
@@ -938,7 +926,7 @@ parse_netprefix(isc_sockaddr_t **sap, const char *value) {
} else if (netmask != 0xffffffff) { } else if (netmask != 0xffffffff) {
int i; int i;
for (i = 0; i < 3; i++) { for (i = 0; i < 3 && strlen(buf) < sizeof(buf) - 2; i++) {
strlcat(buf, ".0", sizeof(buf)); strlcat(buf, ".0", sizeof(buf));
if (inet_pton(AF_INET, buf, &in4) == 1) { if (inet_pton(AF_INET, buf, &in4) == 1) {
parsed = ISC_TRUE; parsed = ISC_TRUE;
@@ -1838,8 +1826,7 @@ parse_args(isc_boolean_t is_batchfile, int argc, char **argv)
/*% Main processing routine for mdig */ /*% Main processing routine for mdig */
int int
main(int argc, char *argv[]) main(int argc, char *argv[]) {
{
struct query *query; struct query *query;
isc_sockaddr_t bind_any; isc_sockaddr_t bind_any;
isc_log_t *lctx; isc_log_t *lctx;
@@ -1867,6 +1854,7 @@ main(int argc, char *argv[])
fatal("could not find either IPv4 or IPv6"); fatal("could not find either IPv4 or IPv6");
mctx = NULL; mctx = NULL;
isc_mem_debugging = ISC_MEM_DEBUGRECORD;
RUNCHECK(isc_mem_create(0, 0, &mctx)); RUNCHECK(isc_mem_create(0, 0, &mctx));
lctx = NULL; lctx = NULL;
@@ -1947,12 +1935,17 @@ main(int argc, char *argv[])
while (query != NULL) { while (query != NULL) {
struct query *next = ISC_LIST_NEXT(query, link); struct query *next = ISC_LIST_NEXT(query, link);
if (query->ecs_addr != NULL) if (query->ecs_addr != NULL) {
isc_mem_free(mctx, query->ecs_addr); isc_mem_free(mctx, query->ecs_addr);
query->ecs_addr = NULL;
}
isc_mem_free(mctx, query); isc_mem_free(mctx, query);
query = next; query = next;
} }
if (default_query.ecs_addr != NULL)
isc_mem_free(mctx, default_query.ecs_addr);
dns_view_detach(&view); dns_view_detach(&view);
dns_requestmgr_shutdown(requestmgr); dns_requestmgr_shutdown(requestmgr);