mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-09-02 07:35:26 +00:00
Code Issues Releases Wiki Activity

possible null dereference in dns_acl_isanyornone() [rt18559]

Browse Source
This commit is contained in:
Evan Hunt
2008-09-12 04:54:39 +00:00
parent 5a0f94e585
commit e80f661db8
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGES
View File

@@ -1,3 +1,6 @@
2439. [bug] Potential NULL dereference in dns_acl_isanyornone().
[RT #18559]
2438. [bug] Timeouts could be logged incorrectly under win32. 2438. [bug] Timeouts could be logged incorrectly under win32.
2437. [bug] Sockets could be closed too early, leading to 2437. [bug] Sockets could be closed too early, leading to

5
lib/dns/acl.c
View File

@@ -15,7 +15,7 @@
* PERFORMANCE OF THIS SOFTWARE. * PERFORMANCE OF THIS SOFTWARE.
*/ */
/* $Id: acl.c,v 1.46 2008/09/10 21:52:49 each Exp $ */ /* $Id: acl.c,v 1.47 2008/09/12 04:54:39 each Exp $ */
/*! \file */ /*! \file */
@@ -144,10 +144,11 @@ dns_acl_isanyornone(dns_acl_t *acl, isc_boolean_t pos)
acl->iptable->radix->head->prefix == NULL) acl->iptable->radix->head->prefix == NULL)
return (ISC_FALSE); return (ISC_FALSE);
if (acl->length != 0 && acl->node_count != 1) if (acl->length != 0 || acl->node_count != 1)
return (ISC_FALSE); return (ISC_FALSE);
if (acl->iptable->radix->head->prefix->bitlen == 0 && if (acl->iptable->radix->head->prefix->bitlen == 0 &&
acl->iptable->radix->head->data[0] != NULL &&
*(isc_boolean_t *) (acl->iptable->radix->head->data[0]) == pos) *(isc_boolean_t *) (acl->iptable->radix->head->data[0]) == pos)
return (ISC_TRUE); return (ISC_TRUE);