From e9bd1496ed7a0da5ef39ce83c3315c87699971b4 Mon Sep 17 00:00:00 2001 From: Evan Hunt Date: Sat, 6 Aug 2016 00:21:04 -0700 Subject: [PATCH] [master] fix dnstap query/response selectors 4427. [bug] The "query" and "response" parameters to the "dnstap" option had their functions reversed. --- CHANGES | 3 +++ bin/named/server.c | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGES b/CHANGES index a43bc97699..ed00130755 100644 --- a/CHANGES +++ b/CHANGES @@ -1,3 +1,6 @@ +4427. [bug] The "query" and "response" parameters to the + "dnstap" option had their functions reversed. + --- 9.11.0b3 released --- 4426. [bug] Addressed Coverity warnings. [RT #42908] diff --git a/bin/named/server.c b/bin/named/server.c index e57f4c5d57..67fa33f2fb 100644 --- a/bin/named/server.c +++ b/bin/named/server.c @@ -2976,9 +2976,9 @@ configure_dnstap(const cfg_obj_t **maps, dns_view_t *view) { } str = cfg_obj_asstring(obj2); - if (strcasecmp(str, "query")) { + if (strcasecmp(str, "query") == 0) { dt &= ~DNS_DTTYPE_RESPONSE; - } else if (strcasecmp(str, "response")) { + } else if (strcasecmp(str, "response") == 0) { dt &= ~DNS_DTTYPE_QUERY; }