mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-30 22:15:20 +00:00
Code Issues Releases Wiki Activity

Get rid of RW locks in the DoH code

Browse Source 
This commit gets rid of RW locks in a hot path of the DoH code. In the
original design, it was implied that we add new endpoints after the
HTTP listener was created. Such a design implies some locking. We do
not need such flexibility, though. Instead, we could build a set of
endpoints before the HTTP listener gets created. Such a design does
not need RW locks at all.
This commit is contained in:
Artem Boldariev
2021-07-13 12:32:47 +03:00
parent ebb670c8f8
commit f388b71378
7 changed files with 277 additions and 138 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
lib/isc/netmgr/netmgr-int.h
View File

@@ -31,7 +31,6 @@
#include <isc/refcount.h>
#include <isc/region.h>
#include <isc/result.h>
#include <isc/rwlock.h>
#include <isc/sockaddr.h>
#include <isc/stats.h>
#include <isc/thread.h>
@@ -783,6 +782,16 @@ typedef struct isc_nm_httpcbarg {
LINK(struct isc_nm_httpcbarg) link;
} isc_nm_httpcbarg_t;
struct isc_nm_http_endpoints {
isc_mem_t *mctx;
ISC_LIST(isc_nm_httphandler_t) handlers;
ISC_LIST(isc_nm_httpcbarg_t) handler_cbargs;
isc_refcount_t references;
atomic_bool in_use;
};
typedef struct isc_nmsocket_h2 {
isc_nmsocket_t *psock; /* owner of the structure */
char *request_path;
@@ -816,9 +825,7 @@ typedef struct isc_nmsocket_h2 {
void *cbarg;
LINK(struct isc_nmsocket_h2) link;
ISC_LIST(isc_nm_httphandler_t) handlers;
ISC_LIST(isc_nm_httpcbarg_t) handler_cbargs;
isc_rwlock_t lock;
isc_nm_http_endpoints_t *listener_endpoints;
bool response_submitted;
struct {