mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-09-01 06:55:30 +00:00
Code Issues Releases Wiki Activity

[master] change RRL log category 'query-errors'

Browse Source 
3575.	[func]		Changed the logging category for RRL events from
			'queries' to 'query-errors'. [RT #33540]
This commit is contained in:
Evan Hunt
2013-05-21 12:20:54 -07:00
parent f9ed68cc5d
commit f3c8e48b95
5 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGES
View File

@@ -1,3 +1,6 @@
3575. [func] Changed the logging category for RRL events from
'queries' to 'query-errors'. [RT #33540]
3574. [doc] The 'hostname' keyword was missing from server-id 3574. [doc] The 'hostname' keyword was missing from server-id
description in the named.conf man page. [RT #33476] description in the named.conf man page. [RT #33476]

6
bin/named/client.c
View File

@@ -1235,8 +1235,7 @@ ns_client_error(ns_client_t *client, isc_result_t result) {
INSIST(rcode != dns_rcode_noerror && INSIST(rcode != dns_rcode_noerror &&
rcode != dns_rcode_nxdomain); rcode != dns_rcode_nxdomain);
wouldlog = (ns_g_server->log_queries && wouldlog = isc_log_wouldlog(ns_g_lctx, DNS_RRL_LOG_DROP);
isc_log_wouldlog(ns_g_lctx, DNS_RRL_LOG_DROP));
rrl_result = dns_rrl(client->view, &client->peeraddr, rrl_result = dns_rrl(client->view, &client->peeraddr,
TCP_CLIENT(client), TCP_CLIENT(client),
dns_rdataclass_in, dns_rdatatype_none, dns_rdataclass_in, dns_rdatatype_none,
@@ -1250,7 +1249,8 @@ ns_client_error(ns_client_t *client, isc_result_t result) {
* NS_LOGCATEGORY_RRL. * NS_LOGCATEGORY_RRL.
*/ */
if (wouldlog) { if (wouldlog) {
ns_client_log(client, NS_LOGCATEGORY_QUERIES, ns_client_log(client,
NS_LOGCATEGORY_QUERY_EERRORS,
NS_LOGMODULE_CLIENT, NS_LOGMODULE_CLIENT,
DNS_RRL_LOG_DROP, DNS_RRL_LOG_DROP,
"%s", log_buf); "%s", log_buf);

7
bin/named/query.c
View File

@@ -6323,9 +6323,10 @@ query_find(ns_client_t *client, dns_fetchevent_t *event, dns_rdatatype_t qtype)
* in QryDropped while slipped responses are counted * in QryDropped while slipped responses are counted
* with other truncated responses in RespTruncated. * with other truncated responses in RespTruncated.
*/ */
if (wouldlog && ns_g_server->log_queries) { if (wouldlog) {
ns_client_log(client, NS_LOGCATEGORY_QUERIES, ns_client_log(client,
NS_LOGMODULE_CLIENT, NS_LOGCATEGORY_QUERY_EERRORS,
NS_LOGMODULE_QUERY,
DNS_RRL_LOG_DROP, DNS_RRL_LOG_DROP,
"%s", log_buf); "%s", log_buf);
} }

4
doc/arm/Bv9ARM-book.xml
View File

@@ -4938,9 +4938,7 @@ category notify { null; };
</para> </para>
<para> <para>
Rate limiting of individual requests Rate limiting of individual requests
is logged in the <command>queries</command> category is logged in the <command>query-errors</command> category.
and can be controlled with the
<command>querylog</command> option.
</para> </para>
</entry> </entry>
</row> </row>

3
lib/dns/rrl.c
View File

@@ -1219,7 +1219,8 @@ dns_rrl(dns_view_t *view,
* Make a log message for the caller. * Make a log message for the caller.
*/ */
if (wouldlog) if (wouldlog)
make_log_buf(rrl, e, rrl->log_only ? "would " : NULL, make_log_buf(rrl, e,
rrl->log_only ? "would rate limit " : "rate limit ",
NULL, ISC_FALSE, qname, ISC_FALSE, NULL, ISC_FALSE, qname, ISC_FALSE,
rrl_result, resp_result, log_buf, log_buf_len); rrl_result, resp_result, log_buf, log_buf_len);