mir/bind
2
0
Fork 0
mirror of https://gitlab.isc.org/isc-projects/bind9 synced 2025-08-22 01:59:26 +00:00
Code Issues Releases Wiki Activity

clean up coccinelle patches for dns_name_copy()

Browse Source 
no need for semantic patches to use dns_name_copynf() any longer.
This commit is contained in:
Evan Hunt 2021-05-21 17:59:09 -07:00
parent b0aadaac8e
commit f3f1cab05e
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
cocci/dns_name_copy-with-result.spatch
View File

@ -5,7 +5,7 @@ statement S;
- V = dns_name_copy(E1, E2, NULL);
- if (V != ISC_R_SUCCESS) S
+ RUNTIME_CHECK(dns_name_copy(E1, E2, NULL) == ISC_R_SUCCESS);
+ dns_name_copy(E1, E2);
@@
expression V, E1, E2;
@ -14,7 +14,7 @@ statement S1, S2;
- V = dns_name_copy(E1, E2, NULL);
- if (V == ISC_R_SUCCESS) S1 else S2;
+ RUNTIME_CHECK(dns_name_copy(E1, E2, NULL) == ISC_R_SUCCESS);
+ dns_name_copy(E1, E2);
+ S2
@@
@ -25,6 +25,6 @@ statement S1, S2;
- V = dns_name_copy(E1, E2, NULL);
- S1
- if (V == ISC_R_SUCCESS) S2
+ RUNTIME_CHECK(dns_name_copy(E1, E2, NULL) == ISC_R_SUCCESS);
+ dns_name_copy(E1, E2):
+ S1
+ S2

8
cocci/dns_name_copy.spatch
View File

@ -3,21 +3,21 @@ expression E1, E2;
@@
- dns_name_copy(E1, E2, NULL);
+ RUNTIME_CHECK(dns_name_copy(E1, E2, NULL) == ISC_R_SUCCESS);
+ dns_name_copy(E1, E2);
@@
expression E1, E2;
@@
- (void)dns_name_copy(E1, E2, NULL);
+ RUNTIME_CHECK(dns_name_copy(E1, E2, NULL) == ISC_R_SUCCESS);
+ dns_name_copy(E1, E2);
@@
expression E1, E2;
@@
- return (dns_name_copy(E1, E2, NULL));
+ RUNTIME_CHECK(dns_name_copy(E1, E2, NULL) == ISC_R_SUCCESS);
+ dns_name_copy(E1, E2);
+ return (ISC_R_SUCCESS);
// ./bin/named/query.c processing broken with this rule, fix manually
@ -27,4 +27,4 @@ expression E1, E2;
//
// - V = dns_name_copy(E1, E2, NULL);
// - RUNTIME_CHECK(V == ISC_R_SUCCESS);
// + RUNTIME_CHECK(dns_name_copy(E1, E2, NULL) == ISC_R_SUCCESS);
// + dns_name_copy(E1, E2);

2
cocci/dns_name_copynf.spatch
View File

@ -3,4 +3,4 @@ expression E1, E2;
@@
- RUNTIME_CHECK(dns_name_copy(E1, E2, NULL) == ISC_R_SUCCESS);
+ dns_name_copynf(E1, E2);
+ dns_name_copy(E1, E2);